Add support for firefox mac installer. Update web_ui pubspec for http.wq #17044

ferhatb · 2020-03-10T00:05:16Z

No description provided.

nturgut · 2020-03-10T00:10:19Z

lib/web_ui/dev/common.dart

-    throw UnimplementedError();
-  }
+  String getFirefoxDownloadFilename(String version) =>
+      'Firefox ${version}.dmg';


question: is there a space between name and version?

nturgut · 2020-03-10T00:13:32Z

lib/web_ui/dev/firefox_installer.dart

-        io.File(path.join(versionDir.path, 'firefox-${version}.tar.bz2'));
-    await download.stream.pipe(downloadedFile.openWrite());
+        io.File(path.join(versionDir.path, PlatformBinding.instance.getFirefoxDownloadFilename(version)));
+    io.IOSink sink = downloadedFile.openWrite();


Thanks! So if we don't do this, we are leaking.

I think we made this error in a few more places :) https://github.com/flutter/engine/blob/master/lib/web_ui/dev/chrome_installer.dart#L190

I'll fix them!

nturgut · 2020-03-10T00:14:39Z

lib/web_ui/dev/firefox_installer.dart

  /// See [version].
  Future<void> _uncompress(io.File downloadedFile) async {
-    final io.ProcessResult unzipResult = await io.Process.run('tar', <String>[
+    io.ProcessResult unzipResult = await io.Process.run('tar', <String>[


nit: why not final?

nturgut · 2020-03-10T00:24:56Z

lib/web_ui/dev/firefox_installer.dart

  // Therefore Firefox installation is implemented only for Linux now.
-  if (!io.Platform.isLinux) {
-    throw UnimplementedError();
+  if (!io.Platform.isLinux && !io.Platform.isMacOS) {


ferhatb · 2020-03-10T01:13:13Z

Merging on infra failure.

….wq (flutter#17044) * Add support for firefox mac installer. Update web_ui pubspec for http.wq * Addressed review comment 'final'

…for http.wq (flutter/engine#17044)

2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089) 2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087) 2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086) 2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084) 2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (flutter#17080)" (flutter/engine#17088) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082) 2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079) 2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081) 2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450) 2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078) 2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072) 2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (flutter#16960)" (flutter/engine#17074) 2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069) 2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067) 2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994) 2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (flutter#16963)" (flutter#17008)" (flutter/engine#17040) 2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044) 2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020) 2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038) 2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960) 2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991) 2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033) 2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)

2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart 4093d08271f6..37530145ff53 (4 commits) (flutter/engine#17090) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia bf355123ae3b..0340292972b9 (9 commits) (flutter/engine#17089) 2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from r_oCI... to 0Z8VF... (flutter/engine#17087) 2020-03-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v32mJ... to X3Xm2... (flutter/engine#17086) 2020-03-11 chinmaygarde@gmail.com Remove the unused method on iOS surface to make the resource context current. (flutter/engine#17084) 2020-03-11 chinmaygarde@gmail.com Revert "Add support for the Metal backend on all iOS builds. (#17080)" (flutter/engine#17088) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/dart ace1d9b9213a..4093d08271f6 (12 commits) (flutter/engine#17082) 2020-03-11 chinmaygarde@google.com Add support for the Metal backend on all iOS builds. (flutter/engine#17080) 2020-03-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d3f67dbf9f36..bf355123ae3b (9 commits) (flutter/engine#17079) 2020-03-11 chinmaygarde@google.com Disable Embedder11yTest::A11yTreeIsConsistent to unblock LUCI. (flutter/engine#17081) 2020-03-10 chinmaygarde@google.com Gather demangled stack traces and report the same to console on crashes. (flutter/engine#16450) 2020-03-10 chinmaygarde@google.com Implement asynchronous texture uploads when using the Metal backend on iOS. (flutter/engine#17046) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/dart 97674262bc29..ace1d9b9213a (14 commits) (flutter/engine#17078) 2020-03-10 egarciad@google.com Add RTree to flow (flutter/engine#16923) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 78dac6dcb222..d3f67dbf9f36 (6 commits) (flutter/engine#17072) 2020-03-10 flar@google.com Revert "Fix bounds of image_filter_layer (#16960)" (flutter/engine#17074) 2020-03-10 chinmaygarde@google.com Use the ELF loader to setup AOT symbols in benchmark runner. (flutter/engine#17051) 2020-03-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 23899c64e3db..78dac6dcb222 (19 commits) (flutter/engine#17069) 2020-03-10 aam@google.com Roll dart to 97674262bc29447dc59d5c93024b18b27d4bcf98. (flutter/engine#17067) 2020-03-10 ferhat@gmail.com [web] Fixes for Firefox & Safari double underline decoration bugs. (flutter/engine#16994) 2020-03-10 dnfield@google.com Avoid capturing this unsafely in MultiFrameCodec (flutter/engine#16824) 2020-03-10 yjbanov@google.com Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (flutter/engine#17040) 2020-03-10 ferhat@gmail.com Add support for firefox mac installer. Update web_ui pubspec for http.wq (flutter/engine#17044) 2020-03-09 yjbanov@google.com fix "TREE INCONSISTENT" noise in compositing_test.dart (flutter/engine#16995) 2020-03-09 yjbanov@google.com Add more child lifecycle tests (flutter/engine#16689) 2020-03-09 chris@bracken.jp Add libfreetype6-dev to desktop Linux dependencies (flutter/engine#17020) 2020-03-09 liyuqian@google.com Disable shell benchmarks (flutter/engine#17038) 2020-03-09 flar@google.com Fix bounds of image_filter_layer (flutter/engine#16960) 2020-03-09 liyuqian@google.com Record fml and shell benchmarks (flutter/engine#16991) 2020-03-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia c56950442dd1..23899c64e3db (11 commits) (flutter/engine#17033) 2020-03-09 yjbanov@google.com use commit date instead of author date (flutter/engine#17032)

Add support for firefox mac installer. Update web_ui pubspec for http.wq

b53ac1c

ferhatb requested review from nturgut and yjbanov March 10, 2020 00:05

googlebot added the cla: yes label Mar 10, 2020

nturgut reviewed Mar 10, 2020

View reviewed changes

Addressed review comment 'final'

6420d7e

nturgut reviewed Mar 10, 2020

View reviewed changes

nturgut approved these changes Mar 10, 2020

View reviewed changes

ferhatb merged commit 7f942f2 into flutter:master Mar 10, 2020

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

8e76634

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 10, 2020

Roll engine 0e2c8feeeb47..7f942f273b1d (9 commits) flutter/flutter#52294

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

20afe1a

…for http.wq (flutter/engine#17044)

This was referenced Mar 10, 2020

Roll engine 0e2c8feeeb47..d41e25b5492d (10 commits) flutter/flutter#52299

Closed

Roll engine 0e2c8feeeb47..a18066bfb3be (11 commits) flutter/flutter#52304

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

d965375

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

2c4a1dc

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 10, 2020

Roll engine 0e2c8feeeb47..a3e883b14971 (12 commits) flutter/flutter#52307

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

5e5582d

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 10, 2020

Roll engine 0e2c8feeeb47..06bb64921efa (13 commits) flutter/flutter#52333

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

7c89a38

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 10, 2020

Roll engine 0e2c8feeeb47..a3e883b14971 (12 commits) flutter/flutter#52344

Closed

ferhatb deleted the firefox_install branch March 10, 2020 21:03

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 10, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

2fde9c5

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 10, 2020

Roll engine 0e2c8feeeb47..220039a9c80e (16 commits) flutter/flutter#52361

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

bf122f2

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..f1ff6a2c19af (19 commits) flutter/flutter#52378

Closed

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..17e07c537e13 (20 commits) flutter/flutter#52380

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

37df528

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

03e6f3c

…for http.wq (flutter/engine#17044)

This was referenced Mar 11, 2020

Roll engine 0e2c8feeeb47..a0010512df4c (22 commits) flutter/flutter#52384

Closed

Roll engine 0e2c8feeeb47..0e8a2f33a83c (23 commits) flutter/flutter#52386

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

53e0a69

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..ec2c624f952d (26 commits) flutter/flutter#52391

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

bafe880

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..2572eff9a6f3 (29 commits) flutter/flutter#52396

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

2dc7c38

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..6d8611d0bd93 (31 commits) flutter/flutter#52399

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

c0c16cc

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..6d8611d0bd93 (31 commits) flutter/flutter#52410

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

11c3080

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..c1111bba8417 (32 commits) flutter/flutter#52424

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

b9990f3

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..6d8611d0bd93 (31 commits) flutter/flutter#52429

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 11, 2020

7f942f2 Add support for firefox mac installer. Update web_ui pubspec …

963d4dd

…for http.wq (flutter/engine#17044)

engine-flutter-autoroll mentioned this pull request Mar 11, 2020

Roll engine 0e2c8feeeb47..6d8611d0bd93 (31 commits) flutter/flutter#52430

Closed

jason-simmons mentioned this pull request Mar 11, 2020

Manual roll engine 0e2c8feeeb47..6d8611d0bd93 (31 commits) flutter/flutter#52431

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for firefox mac installer. Update web_ui pubspec for http.wq #17044

Add support for firefox mac installer. Update web_ui pubspec for http.wq #17044

Uh oh!

ferhatb commented Mar 10, 2020

Uh oh!

nturgut Mar 10, 2020

Uh oh!

ferhatb Mar 10, 2020

Uh oh!

nturgut Mar 10, 2020

Uh oh!

ferhatb Mar 10, 2020

Uh oh!

nturgut Mar 10, 2020

Uh oh!

ferhatb Mar 10, 2020

Uh oh!

nturgut Mar 10, 2020

Uh oh!

ferhatb commented Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add support for firefox mac installer. Update web_ui pubspec for http.wq #17044

Add support for firefox mac installer. Update web_ui pubspec for http.wq #17044

Uh oh!

Conversation

ferhatb commented Mar 10, 2020

Uh oh!

nturgut Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

nturgut Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

nturgut Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

nturgut Mar 10, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb commented Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants