Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jan 3, 2020

The main scenarios that this PR fixes:

  1. Two right clicks in a row but in different locations.
  2. Right click then left click in a different location.
  3. Right click then move the mouse quickly (before the context menu pops up).
  4. Start dragging inside the page, and release the mouse outside, then hover back into the page.

Fixes flutter/flutter#47440

@mdebbar mdebbar added the platform-web Code specifically for the web engine label Jan 3, 2020
@mdebbar mdebbar requested review from chunhtai and dkwingsmt January 3, 2020 01:10
@mdebbar mdebbar self-assigned this Jan 3, 2020
@auto-assign auto-assign bot requested a review from gw280 January 3, 2020 01:10
@mdebbar mdebbar removed the request for review from gw280 January 3, 2020 01:10
@mdebbar mdebbar requested review from chunhtai and dkwingsmt January 3, 2020 05:14
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdebbar
Copy link
Contributor Author

mdebbar commented Jan 3, 2020

The Fuchsia failure is unrelated to this PR.

@mdebbar mdebbar merged commit eb13993 into flutter:master Jan 3, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 3, 2020
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 3, 2020
flutter/engine@5858519...eb13993

git log 5858519..eb13993 --first-parent --oneline
2020-01-03 mouad.debbar@gmail.com [web] Fix right click issues (flutter/engine#15103)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC franciscojma@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
kakaka11 added a commit to kakaka11/flutter that referenced this pull request Jan 3, 2020
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@mdebbar mdebbar deleted the fix_state_down branch April 15, 2021 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes platform-web Code specifically for the web engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flutter web: assertion on mouse click

4 participants