This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove extra shadows from ParagraphStyle #13805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
Nov 13, 2019
ferhatb
reviewed
Nov 13, 2019
Contributor
ferhatb
left a comment
ferhatb
left a comment
There was a problem hiding this comment.
applyParagraphStyle needs shadow removed too
Contributor
|
It would appear from the test failures that not all references to _shadows were removed. |
Contributor
|
Yes. applyParagraphStyle is the one still referencing.
…On Wed, Nov 13, 2019 at 10:25 AM Jim Graham ***@***.***> wrote:
It would appear from the test failures that not all references to _shadows
were removed.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#13805?email_source=notifications&email_token=ABGTTKW4CEZYKF336FDDDC3QTRBCHA5CNFSM4JMOBXRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED7E3BA#issuecomment-553536900>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGTTKU3JXH27ZP43VI544TQTRBCHANCNFSM4JMOBXRA>
.
|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ParagraphStyle does not have shadows. This should be removed.
For reference: db23a6c