Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@lambdabaa
Copy link
Contributor

@bkonyi
Copy link
Contributor

bkonyi commented Nov 12, 2019

RSLGTM

@devoncarew
Copy link
Contributor

@bkonyi - it looks like the model skew was introduced ~7 days ago with fcd8a21. Do you know how we rev these deps from dart into flutter/engine? It would be good to figure out a process to avoid this in the future.

@devoncarew
Copy link
Contributor

@lambdabaa - can you mark the affected flutter dev builds as bad? The process is here: https://github.com/flutter/flutter/wiki/Bad-Build-Identification; we'd start from the above commit, and use the commit when this lands as the fix commit.

@bkonyi
Copy link
Contributor

bkonyi commented Nov 12, 2019

@bkonyi - it looks like the model skew was introduced ~7 days ago with fcd8a21. Do you know how we rev these deps from dart into flutter/engine? It would be good to figure out a process to avoid this in the future.

A quick look at the DEPS file shows that we aren't using a Var to declare the revision for the model like we do for most of our dependencies. Both the DEPS file in this and the dart-lang/sdk repositories will need to be updated to utilize that format for the autoroller to pick it up (see create_updated_flutter_deps.py in engine/src/tools/dart for code that updates the Flutter engine DEPS).

@devoncarew
Copy link
Contributor

Thanks for the investigation!

@lambdabaa - it sounds like we should make that change in this file (and a similar change in the dart-lang/sdk DEPS file).

@lambdabaa lambdabaa merged commit 198c2a7 into master Nov 13, 2019
@lambdabaa lambdabaa deleted the lambdabaa-patch-1 branch November 13, 2019 17:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RangeError (end): Invalid value: Not in range 0..50, inclusive: 56 from LanguageModel.predictWithScores

5 participants