-
Notifications
You must be signed in to change notification settings - Fork 6k
Update version of dart/language_model distributed with flutter engine to latest #13799
Conversation
|
RSLGTM |
|
@lambdabaa - can you mark the affected flutter dev builds as bad? The process is here: https://github.com/flutter/flutter/wiki/Bad-Build-Identification; we'd start from the above commit, and use the commit when this lands as the fix commit. |
A quick look at the DEPS file shows that we aren't using a Var to declare the revision for the model like we do for most of our dependencies. Both the DEPS file in this and the dart-lang/sdk repositories will need to be updated to utilize that format for the autoroller to pick it up (see create_updated_flutter_deps.py in engine/src/tools/dart for code that updates the Flutter engine DEPS). |
|
Thanks for the investigation! @lambdabaa - it sounds like we should make that change in this file (and a similar change in the dart-lang/sdk DEPS file). |
…r engine to latest (flutter/engine#13799)
…r engine to latest (flutter/engine#13799)
…r engine to latest (flutter/engine#13799)
…r engine to latest (flutter/engine#13799)
…r engine to latest (flutter/engine#13799)
Fixes dart-lang/sdk#39352.