This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Move TextRange from the framework to dart:ui. #13747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
gspencergoog
force-pushed
the
move_text_range
branch
2 times, most recently
from
9d32559 to
b306855
Compare
Contributor
Author
|
Build failure is expected, and will be fixed when rolling this change to flutter/flutter with flutter/flutter#44422 |
GaryQian
reviewed
Nov 8, 2019
| /// [end] must either be greater than or equal to zero or both exactly -1. | ||
| /// | ||
| /// Instead of creating an empty text range, consider using the [empty] | ||
| /// constant. |
Contributor
There was a problem hiding this comment.
Should clarify if a range includes end or not up here. Newer coders will look for this info.
Contributor
Author
There was a problem hiding this comment.
Good call. Will add.
gspencergoog
force-pushed
the
move_text_range
branch
from
b306855 to
b7b84c2
Compare
Contributor
Author
|
At @jonahwilliams's suggestion, I am going to revert the API change that converts to returning the |
gspencergoog
force-pushed
the
move_text_range
branch
from
b7b84c2 to
aa46dd5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 9, 2019
git@github.com:flutter/engine.git/compare/5f5713e33971...af04338 git log 5f5713e..af04338 --no-merges --oneline 2019-11-08 a-siva@users.noreply.github.com Manual roll of Dart e68ca9b652acdb642668a6acb5f630d5be6c03da...fa4379946109467c8a48f20f19d83d7c72968a3e (flutter/engine#13756) 2019-11-08 ychris@google.com Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13755)" (flutter/engine#13757) 2019-11-08 ferhat@gmail.com [web] Support gif/webp animations, Speed up image drawing in BitmapCanvas. (flutter/engine#13748) 2019-11-08 ychris@google.com Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13755) 2019-11-08 gspencergoog@users.noreply.github.com Move TextRange from the framework to dart:ui. (flutter/engine#13747) 2019-11-08 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8c1e265f6f81..c88d1774ed50 (7 commits) (flutter/engine#13754) 2019-11-08 ychris@google.com Revert "Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (#13314)" (flutter/engine#13753) 2019-11-08 ychris@google.com Always use `IOSGLContextSwitch` to access EAGLContexts to prevent plugins from polluting Flutter's EAGLContext (flutter/engine#13314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC garyq@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
TextRangefrom the framework and moves it to the engine, in preparation for using it to return text ranges from the text extent APIs, and updates the APIs that useParagraph.getWordBoundary(there was only one) to return aTextRangeinstead of aList<int>.This will require a manual engine roll, because of needing to remove the duplicate class in the framework.
Added new tests for
TextRange.