Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@devoncarew
Copy link
Contributor

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGT @jonahwilliams

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devoncarew devoncarew merged commit b2e7e49 into flutter:master Oct 14, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 15, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 15, 2019
git@github.com:flutter/engine.git/compare/66bf00bca361...49a8e45

git log 66bf00b..49a8e45 --no-merges --oneline
2019-10-15 CptBlackPixel Adding deviceId to KeyEventChannel enconding method (flutter/engine#12958)
2019-10-14 47866232+chunhtai@users.noreply.github.com Enable all engine test on windows (flutter/engine#12814)
2019-10-14 devoncarew@google.com add the dart:__interceptors library to the dart sdk (flutter/engine#13125)
2019-10-14 bkonyi@google.com Roll src/third_party/dart 892fcf2c45..70a7ef3f58 (9 commits)
2019-10-14 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7e1b45d9c28..7d7aaf46aeb4 (19 commits) (flutter/engine#13127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
git@github.com:flutter/engine.git/compare/66bf00bca361...49a8e45

git log 66bf00b..49a8e45 --no-merges --oneline
2019-10-15 CptBlackPixel Adding deviceId to KeyEventChannel enconding method (flutter/engine#12958)
2019-10-14 47866232+chunhtai@users.noreply.github.com Enable all engine test on windows (flutter/engine#12814)
2019-10-14 devoncarew@google.com add the dart:__interceptors library to the dart sdk (flutter/engine#13125)
2019-10-14 bkonyi@google.com Roll src/third_party/dart 892fcf2c45..70a7ef3f58 (9 commits)
2019-10-14 skia-flutter-autoroll@skia.org Roll src/third_party/skia a7e1b45d9c28..7d7aaf46aeb4 (19 commits) (flutter/engine#13127)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose JavaScriptObject from dart:js

4 participants