This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Test child isolates are terminated when root is shutdown #13048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Oct 10, 2019
Member
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Some nits about the unused object. But otherwise LGTM. Thanks.
runtime/dart_isolate_unittests.cc
Outdated
| TEST_F(DartIsolateTest, RootIsolateShutdownStopsChildIsolates) { | ||
| ASSERT_FALSE(DartVMRef::IsInstanceRunning()); | ||
| fml::CountDownLatch latch(9); | ||
| fml::CountDownLatch shutdown_latch(4); |
Member
There was a problem hiding this comment.
Isn't this latch redundant? You are not going to count down on the latch above 9 times unless 4 of them are also from the shutdown? Your call on if you think is clearer though.
runtime/dart_isolate_unittests.cc
Outdated
| }; | ||
| auto vm_ref = DartVMRef::Create(settings); | ||
| auto vm_data = vm_ref.GetVMData(); | ||
| TaskRunners task_runners(GetCurrentTestName(), // |
Member
There was a problem hiding this comment.
These task runners are not necessary and not being used at all.
Member
There was a problem hiding this comment.
You created a new thread for it explicitly below.
chinmaygarde
added a commit
that referenced
this pull request
Oct 10, 2019
)" This reverts commit e96c740.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2019
git@github.com:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (#13048)" (flutter/engine#13067) 2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048) 2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (flutter#13048)" (flutter/engine#13067) 2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048) 2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies flutter/flutter#20764