This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow embedders to specify arbitrary data to the isolate on launch. #13047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fml/mapping.cc
Outdated
| } | ||
|
|
||
| DataMapping::DataMapping(const std::string& string) | ||
| : DataMapping(CreateVectorFromString(string)) {} |
Member
There was a problem hiding this comment.
this can be reduced to data_(string.begin(), string.end())
lib/ui/window.dart
Outdated
| /// This data is persistent for the duration of the Flutter application and is | ||
| /// available even after isolate restarts. Because of this lifecycle, the size | ||
| /// of this data must be kept to a minimum and platform channels used for | ||
| /// communication that does not require synchronous embedder to isolate |
Member
There was a problem hiding this comment.
I think this would be easier to understand if the part about platform channels was split into another sentence.
lib/ui/window/window.cc
Outdated
| return; | ||
| } | ||
|
|
||
| auto data_handle = Dart_NewTypedData(Dart_TypedData_kByteData, |
Member
There was a problem hiding this comment.
Reuse ToByteDatahere. ToByteData can use void* and length arguments, and you can add wrappers that take an fml::Mapping or vector
Tonic's DartByteData class might also be a good place for this helper function.
Member
Author
|
Addressed all comments. |
jason-simmons
approved these changes
Oct 10, 2019
chinmaygarde
force-pushed
the
launch_data
branch
from
4ee9572 to
6314042
Compare
Since this is currently only meant to be used by the embedding internally, the setter in Objective-C is only exposed via the FlutterDartProject private class extension. Unit tests have been added to the shell_unittests harness. Fixes flutter/flutter#37641
chinmaygarde
force-pushed
the
launch_data
branch
from
7096aa6 to
dada016
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 10, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 10, 2019
git@github.com:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (#13048)" (flutter/engine#13067) 2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048) 2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/5162413111b8...cef6751 git log 5162413..cef6751 --no-merges --oneline 2019-10-10 chinmaygarde@gmail.com Revert "Test child isolates are terminated when root is shutdown (flutter#13048)" (flutter/engine#13067) 2019-10-10 garyq@google.com Test child isolates are terminated when root is shutdown (flutter/engine#13048) 2019-10-10 chinmaygarde@google.com Allow embedders to specify arbitrary data to the isolate on launch. (flutter/engine#13047) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is currently only meant to be used by the embedding internally, the setter in Objective-C is only exposed via the FlutterDartProject private class extension. Unit tests have been added to the shell_unittests harness.
Fixes flutter/flutter#37641