Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Analyze framework Dart code in presubmit tests #13037

Merged
merged 3 commits into from
Oct 12, 2019
Merged

Analyze framework Dart code in presubmit tests #13037

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0e4f5c
Analyze framework Dart code in presubmit tests
liyuqian Oct 9, 2019
471bc64
Analyze before test
liyuqian Oct 9, 2019
55606f5
Add `flutter update-packages`
liyuqian Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@ task:
cd $FRAMEWORK_PATH/flutter/dev/integration_tests/web
../../../bin/flutter config --local-engine=host_debug_unopt --no-analytics --enable-web
../../../bin/flutter --local-engine=host_debug_unopt build web -v
analyze_framework_script: |
Copy link
Contributor

@dnfield dnfield Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe do analysis before test?

Copy link
Contributor Author

@liyuqian liyuqian Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

cd $FRAMEWORK_PATH/flutter
rm -rf bin/cache/pkg/sky_engine
cp -r $ENGINE_PATH/src/out/host_debug_unopt/gen/dart-pkg/sky_engine bin/cache/pkg/
bin/flutter update-packages --local-engine=host_debug_unopt
bin/flutter analyze --dartdocs --flutter-repo --local-engine=host_debug_unopt
test_framework_script: |
cd $FRAMEWORK_PATH/flutter/packages/flutter
../../bin/flutter test --local-engine=host_debug_unopt
Expand Down