Commits on Sep 9, 2024

1. Roll Skia from 7ad1252da14f to 7e659d5538fa (2 revisions) (#55050) …

   https://skia.googlesource.com/skia.git/+log/7ad1252da14f..7e659d5538fa
   
   2024-09-09 borenet@google.com [bazel] Move win_toolchain dep into download_toolchains_for_skia
   2024-09-09 kjlubick@google.com Remove unneeded SK_GRAPHITE guards
   
   If this roll has caused a breakage, revert this CL and stop the roller
   using the controls here:
   https://autoroll.skia.org/r/skia-flutter-autoroll
   Please CC brianosman@google.com,bwils@google.com,codefu@google.com,rmistry@google.com on the revert to ensure that a human
   is aware of the problem.
   
   To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
   To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
   
   To report a problem with the AutoRoller itself, please file a bug:
   https://issues.skia.org/issues/new?component=1389291&template=1850622
   
   Documentation for the AutoRoller is here:
   https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

   

   skia-flutter-autoroll authored Sep 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for d4d6dfd
   • Browse repository at this point

   Copy the full SHA

   d4d6dfd View commit details

   Browse the repository at this point in the history

2. Unskip Impeller iOS scenario tests (#55012) …

   The iOS golden scenario tests are supposed to run on Skia and Impeller, but are actually running on Skia twice.  
   
   #### Issue 1: script-side
   
   Regression from #46329.
   Currently, the tests log "Running simulator tests with Impeller" but then you see that it's not:
   ```
   Running simulator tests with Impeller
   ...
   2024-09-06 13:38:07.692810-0700 Scenarios[73857:470266] [IMPORTANT:flutter/shell/common/shell.cc(456)] [Action Required] The application opted out of Impeller by either using the --no-enable-impeller flag or FLTEnableImpeller=false plist flag. This option is going to go away in an upcoming Flutter release. Remove the explicit opt-out. If you need to opt-out, report a bug describing the issue.
   ```
   https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8737514337106072353/+/u/test:_Scenario_App_Integration_Tests/stdout
   
   `INFOPLIST_FILE="Scenarios/Info_Impeller.plist"` isn't passed into the xcodebuild any more.  I confirmed #46329 caused this by inserting a comment in the middle of the `xcodebuild` command, which caused the last argument after the comment to not be passed in.
   
   #### Issue 2: test-side
   
   Regression from #45093.
   [The logic deciding whether to use Skia or Impeller goldens is incorrect](https://github.com/flutter/engine/blob/397987aedeb4ed41ec945fcbe9d347e579513bf4/testing/scenario_app/ios/Scenarios/ScenariosUITests/GoldenTestManager.m#L84-L90) since `FLTEnableImpeller` is set in the app Info.plist, not the UI test, so the bundle should be "dev.flutter.Scenarios". That means even if the script was passing in the right Info.plist, the tests would fail since they would have compared the Skia screenshots.
   
   #### This PR
   
   1. Once #55016 merges (edit: done), these tests will no longer be running with the software renderer.  Remove all the test skips so they all run on Impeller.
   2. Add the missing Impeller golden screenshots.
   3. Update the default Info.plist to use Impeller, so if another script mishap happens, it will default to testing Impeller twice, and not Skia.  Add a Skia Info.plist variant instead.
   4. Update the test logic to check the right bundle ID Info.plist to decide whether to compare against the Skia or Impeller screenshots.  Prefer Impeller so if another test-side mishap happens, it will also default to testing Impeller and not Skia.  It will only use the Skia goldens if the bool is set in the Info.plist, and that bool is NO (not just if it's missing).
   5. All this made the now-default Impeller tests pass, but when passing in `INFOPLIST_FILE="Scenarios/Info_Skia.plist"` the app wasn't launching, with the error:
   
   > Scenarios encountered an error (Failed to install or launch the test runner. (Underlying Error: Simulator device returned an error for the requested operation. Failed to create promise. (Underlying Error: Failed to create app extension placeholder for /Users/chrome-bot/Library/Developer/Xcode/DerivedData/Scenarios-aypjgouuxctxctfazxalyegcximf/Build/Products/Debug-iphonesimulator/Scenarios.app/PlugIns/ScenariosShare.appex. Failed to create promise. (Underlying Error: Failed to set placeholder attributes dev.flutter.Scenarios.ScenariosShare. Failed to create promise. (Underlying Error: extensionDictionary must be set in placeholder attributes for an app extension placeholder. Invalid placeholder attributes.)))))
   
   This is identical to the error in #53717. I finally realized it was because the ScenariosShare app extension requires specific extension keys in its plist, which weren't present in the app Info.plist at `Scenarios/Info_Skia.plist`.  So I changed the `INFOPLIST_FILE` path to `$(TARGET_NAME)/Info_Skia.plist` so it would resolve to target-specific copies like `Scenarios/ScenariosShare/Info_Skia.plist`.  That meant I had to add a few more copies where they didn't exist in the target path.
   
   Dependent on #55016 landing.
   Fixes flutter/flutter#131888
   
   [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

   

   jmagman authored Sep 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 656117f
   • Browse repository at this point

   Copy the full SHA

   656117f View commit details

   Browse the repository at this point in the history