Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a7af55c56aa6
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a924a9017d7
Choose a head ref
  • 10 commits
  • 29 files changed
  • 7 contributors

Commits on Sep 19, 2023

  1. [ios] scenario test make parent view controller hide status bar (#46065) 

    The parent view controller of FlutterViewController in `non_full_screen_flutter_view_platform_view` does not explicitly set the status bar hidden. iOS 17 will show the status bar causing the golden to be no deterministic. 

Part of flutter/flutter#133207

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    08ee602 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Adds unit test to make sure we can encode bgr101010xr to p… 

    …ng. (#46007)

fixes flutter/flutter#133942

This is current blocked on the skia bug: https://g-issues.skia.org/issues/300986800
Depends on skia fix: https://skia-review.googlesource.com/c/skia/+/757816

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    6fc076b View commit details
    Browse the repository at this point in the history

  3. Conform to clang_tidy in client_wrapper headers. (#46058) 

    Partial work towards flutter/flutter#134969.

All of these were auto-suggested by Clang, and mostly avoid unnecessary
copies.
    @matanlurey
    matanlurey authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7c6032d View commit details
    Browse the repository at this point in the history

  4. Made the warning about downgrading wide gamut happen at the correct t… 

    …ime (#46064)

fixes flutter/flutter#135033

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3171f20 View commit details
    Browse the repository at this point in the history

  5. Properly transfer objects between the main thread and web worker. (#4… 

    …6061)

We need to make sure to add objects to the transfer list when we send them across the ui thread/web worker boundary. Otherwise, they get copied, which is very expensive.

On my M1 MacBook Pro, I took measurements of scrolling in the material 3 demo. Before this change, the work on the web worker thread was taking about 25-40ms per frame. After the change, it's around 2ms.
    @eyebrowsoffire
    eyebrowsoffire authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    556c613 View commit details
    Browse the repository at this point in the history

  6. [Impeller] adds hardware gate for wide gamut (#46051) 

    fixes flutter/flutter#133015

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    82d484b View commit details
    Browse the repository at this point in the history

  7. Roll Skia from fe3568162721 to 1a8885b9e03c (6 revisions) (#46075) 

    https://skia.googlesource.com/skia.git/+log/fe3568162721..1a8885b9e03c

2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 6fbc053bdad0 to a5a762c16294
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 4880b92b4f1c to 927fde2f2c6e
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 75c3a7bb1f19 to b4ee53fe6042
2023-09-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 3c3b69cdbecd to 5a23365ca776
2023-09-19 johnstiles@google.com Fix a few more GCC warnings.
2023-09-19 bungeman@google.com Revert "Enforce IWYU on more src/core files"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jonahwilliams@google.com,rmistry@google.com,tdenniston@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0d7db40 View commit details
    Browse the repository at this point in the history

  8. [Impeller] Fix validation errors in RendererTest. (#46076) 

    Vulkan validation was tripping on the fact that renderer tests were rendering to the root render pass. This root render pass doesn't contain a stencil buffer. However, `MakeDefaultPipelineDescriptor` assumes a stencil and color attachment. The other backends are resilient to this mismatch since there is no compat render pass created upfront. But Vulkan was sad. This should only happen in the low level tests. In the higher levels of the framework, we have variants that make sure there is a pipeline pass and render pass compatibility.

Fixes validations of the kind:

```
--- Vulkan Debug Report  ----------------------------------------
|                Severity: Error
|                    Type: { Validation }
|                 ID Name: VUID-vkCmdDraw-renderPass-02684
|               ID Number: 1349015333
|       Queue Breadcrumbs: [NONE]
|  CMD Buffer Breadcrumbs: [NONE]
|         Related Objects: RenderPass [16305153808034431137] [Playground Render Pass], RenderPass [18100546345029861533] [Compat Render Pass: BoxFade Pipeline]
|                 Trigger: Validation Error: [ VUID-vkCmdDraw-renderPass-02684 ] Object 0: handle = 0xe2478b00000000a1, name = Playground Render Pass, type = VK_OBJECT_TYPE_RENDER_PASS; Object 1: handle = 0xfb320f000000009d, name = Compat Render Pass: BoxFade Pipeline, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0x50685725 | vkCmdDraw: RenderPasses incompatible between active render pass w/ VkRenderPass 0xe2478b00000000a1[Playground Render Pass] and pipeline state object w/ VkRenderPass 0xfb320f000000009d[Compat Render Pass: BoxFade Pipeline] Attachment 4294967295 is not compatible with 1: The first is unused while the second is not.. The Vulkan spec states: The current render pass must be compatible with the renderPass member of the VkGraphicsPipelineCreateInfo structure specified when creating the VkPipeline bound to VK_PIPELINE_BIND_POINT_GRAPHICS (https://vulkan.lunarg.com/doc/view/1.3.224.1/mac/1.3-extensions/vkspec.html#VUID-vkCmdDraw-renderPass-02684)
-----------------------------------------------------------------

```
    @chinmaygarde
    chinmaygarde authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    bf58df8 View commit details
    Browse the repository at this point in the history

  9. [Impeller] Affinity adjustments for Vulkan backend. (#46063) 

    Runs the waiter threads with efficiency affinity and the worker thread with "not performance" affinity.
    Jonah Williams authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    99053b9 View commit details
    Browse the repository at this point in the history

  10. [Impeller] Fix validation error about incorrect aspect on buffer to t… 

    …exture copies. (#46078)

This shows up when we try to set the contents of a depth of stencil image. The aspect was assumed to be color only because typical Impeller workloads have device-transient depth and stencil images. But the "stencil mask" test apparently does set the context directly. Besides, this is perfectly valid usage. This makes Vulkan resilient to said usage.
    @chinmaygarde
    chinmaygarde authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5a924a9 View commit details
    Browse the repository at this point in the history
Loading