Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a342a9186e69
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2586cbeeae37
Choose a head ref
  • 14 commits
  • 34 files changed
  • 8 contributors

Commits on May 22, 2023

  1. [Impeller] remove final cmd buffer waitUntilScheduled on physical iOS (

    …#42160)
    
    From local testing, this doesn't seem to be necessary on physical iOS devices, with or without platform views.
    jonahwilliams authored May 22, 2023
    Configuration menu
    Copy the full SHA
    8e6497f View commit details
    Browse the repository at this point in the history
  2. [Impeller] Add UV compute shader. (#42192)

    Adds a compute shader that computes the UV mapping for an arbitrary geometry. Use it with drawPoints since I didn't realize it was possible to use an image shader with this � .
    jonahwilliams authored May 22, 2023
    Configuration menu
    Copy the full SHA
    c7acf57 View commit details
    Browse the repository at this point in the history
  3. [Impeller] Use untransformed text bounds to calculate the size of Col…

    …orSourceTextContents (#42142)
    
    Previously this was attempting to invert the TransformBounds done by GetCoverage.  TransformBounds computes a bounding box of the transformed rectangle and can not be reversed.
    
    Fixes flutter/flutter#127103
    jason-simmons authored May 22, 2023
    Configuration menu
    Copy the full SHA
    d95dfc8 View commit details
    Browse the repository at this point in the history
  4. Reland "[ios_platform_view] only recycle maskView when the view is ap…

    …plying mutators #41573" (#42115)
    
    The original PR (#41573) was reverted due to flutter/flutter#126951
    
    The issue will be fixed in #42079
    
    This needs to be landed after #42079
    
    fixes: flutter/flutter#125620
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored May 22, 2023
    Configuration menu
    Copy the full SHA
    266524c View commit details
    Browse the repository at this point in the history
  5. Again a two-word super tiny typo (#42181)

    Find this when reading source code today...
    
    Btw, what about introducing a spell checker to Flutter source code? ;)
    
    ## Pre-launch Checklist
    
    - [ ] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [ ] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [ ] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [ ] I added new tests to check the change I am making or feature I am
    adding, or Hixie said the PR is test-exempt. See [testing the engine]
    for instructions on writing and running engine tests.
    - [ ] I updated/added relevant documentation (doc comments with `///`).
    - [ ] I signed the [CLA].
    - [ ] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    fzyzcjy authored May 22, 2023
    Configuration menu
    Copy the full SHA
    ac29a74 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1095102 View commit details
    Browse the repository at this point in the history
  7. Roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (#42224)

    https://dart.googlesource.com/sdk.git/+log/b3e1eeda4918..1ca8f8368ecc
    
    2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-134.0.dev
    2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-133.0.dev
    2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-132.0.dev
    2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-131.0.dev
    2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-130.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored May 22, 2023
    Configuration menu
    Copy the full SHA
    2a325ee View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. [fuchsia] Bind ChildViewWatcher on platform thread (#42222)

    This CL posts ChildViewWatcher calls on platform thread.
    
    Bug: fxb/125256
    uysalere authored May 23, 2023
    Configuration menu
    Copy the full SHA
    a1101e9 View commit details
    Browse the repository at this point in the history
  2. Make FML_LOG safe from static initialization (#42219)

    I ran into this while trying to get some printing going for places where we're creating thread local keys. 
    
    Supposedly, just including `<iostream>` should statically initialize `std::cout/cerr`, but it gets really hard to reason about whether your statically initialized code is going to be initialized before or after that happens. I tried making sure that the TU for `fml/logging.cc` did that initialization statically, but that also failed in the verison of the test included here (it passed in some other iterations that modified run_all_unittests.cc). We _could_ make sure it happens each and every time we touch `std::cerr` but ... we could also just use `fprintf(stderr, ...)` and it works just fine.
    
    /cc @flar who ran into problems around this a little while back and was asking about it.
    dnfield authored May 23, 2023
    Configuration menu
    Copy the full SHA
    41e8d52 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from d448fe07ea46 to ac87929b3d2e (8 revisions) (#42226)

    https://skia.googlesource.com/skia.git/+log/d448fe07ea46..ac87929b3d2e
    
    2023-05-22 brianosman@google.com Replace SkOpts::hash/hash_fn with SkChecksum::Hash32
    2023-05-22 jamesgk@google.com Make destcolor GM non-Ganesh-specific
    2023-05-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dc49e5c6de1e to e2fe2393abb4 (1 revision)
    2023-05-22 brianosman@google.com Add wyhash as SkChecksum::Hash32/64
    2023-05-22 brianosman@google.com Make ChecksumBench much more interesting and representative
    2023-05-22 michaelludwig@google.com Revert "[skif] Add FilterResult::Builder and update SkMergeImageFilter to use it"
    2023-05-22 johnstiles@google.com Add WGSL support for anonymous function parameters.
    2023-05-22 robertphillips@google.com Add Protected checks to GL and Mock onCanCopySurface methods
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    8b6617e View commit details
    Browse the repository at this point in the history
  4. Manual roll Dart SDK from b3e1eeda4918 to 1ca8f8368ecc (5 revisions) (#…

    …42229)
    
    Manual roll requested by aam@google.com
    
    https://dart.googlesource.com/sdk.git/+log/b3e1eeda4918..1ca8f8368ecc
    
    2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-134.0.dev
    2023-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-133.0.dev
    2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-132.0.dev
    2023-05-20 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-131.0.dev
    2023-05-19 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.1.0-130.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC aam@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    fc33d07 View commit details
    Browse the repository at this point in the history
  5. Roll Fuchsia Mac SDK from QAwORJOkyNl4J3x4Y... to DzmjiSg6XC0JUfbKP... (

    #42227)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-mac-sdk-flutter-engine
    Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    94f5ee6 View commit details
    Browse the repository at this point in the history
  6. Roll Skia from ac87929b3d2e to 6a57876d0e44 (2 revisions) (#42230)

    https://skia.googlesource.com/skia.git/+log/ac87929b3d2e..6a57876d0e44
    
    2023-05-22 nscobie@google.com Revert "Disable thinLTO in skia  for riscv"
    2023-05-22 scroggo@google.com Revert "[skottie] Don't revalidate during render()"
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,rmistry@google.com,scroggo@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored May 23, 2023
    Configuration menu
    Copy the full SHA
    0ef9f91 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2586cbe View commit details
    Browse the repository at this point in the history
Loading