-
Notifications
You must be signed in to change notification settings - Fork 6k
Comparing changes
Open a pull request
base repository: flutter/engine
base: 878f593802e1
head repository: flutter/engine
compare: c1b0e18a70b3
- 13 commits
- 63 files changed
- 8 contributors
Commits on Nov 18, 2024
-
Roll Skia from 0b74d5c3eb4f to 0d24bd3268ef (1 revision) (#56680)
https://skia.googlesource.com/skia.git/+log/0b74d5c3eb4f..0d24bd3268ef 2024-11-18 borenet@google.com Revert "[infra] Remove P400 jobs from CQ" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for b79353d - Browse repository at this point
Copy the full SHA b79353dView commit details -
Flutter views can gain focus (#54985)
I am unsure why the `tabindex` was removed when semantics were enabled. It seems this change was made without a clear explanation (by me). This PR shouldn't cause any issues as Flutter Views already have a tabindex, we're not adding a new one. This change is necessary because the semantics text strategy refocuses the view on deactivation, requiring the Flutter view to be focusable. ThIs PR is a requirement to enable #54966. flutter/flutter#153022 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for dec7eb9 - Browse repository at this point
Copy the full SHA dec7eb9View commit details -
Roll Skia from 0d24bd3268ef to b79e71223284 (1 revision) (#56683)
https://skia.googlesource.com/skia.git/+log/0d24bd3268ef..b79e71223284 2024-11-18 vigneshv@google.com SkCrabbyAvifCodec: Compute fGainmapMathColorSpace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 03af645 - Browse repository at this point
Copy the full SHA 03af645View commit details -
Re-land "Remove
android_jit_release_x86
." (#56681)Reverts #56634 (flutter/flutter#159011 has merged).
Configuration menu - View commit details
-
Copy full SHA for 68ef504 - Browse repository at this point
Copy the full SHA 68ef504View commit details -
iOS,macOS: Enable ARC in flutter_cflags_objc[c] (#56685)
Enables the `-fobjc-arc` compiler flag for Objective-C and Objective-C++ translation units. Eliminates the flutter_cflags_objc[c]_arc settings, since they're now redundant. All Obj-C/Obj-C++ code in our codebase has now been migrated to ARC. Issue: flutter/flutter#137801
Configuration menu - View commit details
-
Copy full SHA for e1a38ed - Browse repository at this point
Copy the full SHA e1a38edView commit details -
Update the Skia build scripts for a refactoring of the Fontconfig fon…
…t manager (#56684) Skia is reorganizing some font managers, and the Flutter engine's build scripts need to match the changes made to Skia. See https://skia-review.googlesource.com/c/skia/+/915316
Configuration menu - View commit details
-
Copy full SHA for 4573b0c - Browse repository at this point
Copy the full SHA 4573b0cView commit details -
Roll Skia from b79e71223284 to 492e8347d7a4 (2 revisions) (#56687)
https://skia.googlesource.com/skia.git/+log/b79e71223284..492e8347d7a4 2024-11-18 maxhudnell@google.com add triangulated gradient effect 2024-11-18 vigneshv@google.com SkCrabbyAvifCodec: Add RGB565 support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for 635dee8 - Browse repository at this point
Copy the full SHA 635dee8View commit details -
Extract TestGLContext to separate translation unit (#56647)
For consistency with the Test.*Context classes for other backends, which live in their own implementation file with their own header, extract TestEGLContext to its own header and TU so that in cases where only a TestEGLContext is required (e.g. EmbedderTestBackingStoreProducerGL), we don't need to include all the various test GL surface classes as well. GetEGLError is used by both TestEGLContext and the TestGLSurface classes, so moves to its own utils file. No tests because this is a refactoring with no semantic changes, and the code itself is test code. Issue: flutter/flutter#158998 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 7f2d56b - Browse repository at this point
Copy the full SHA 7f2d56bView commit details -
[skwasm] Use
displayWidth
/displayHeight
instead ofcodedWidth
/`……codedHeight` (#56686) This addresses flutter/flutter#159088 If the image is rotated in its exif data, the coded width/height may differ from the display width/height. It's important to use the display width/height so that `texImage2D` does the right thing with the `VideoFrame`.
Configuration menu - View commit details
-
Copy full SHA for b9b57a9 - Browse repository at this point
Copy the full SHA b9b57a9View commit details -
iOS: Eliminate unguarded-availability opt-out (#56689)
Eliminates the opt-out of `-Wunguarded-availability-new` in the `ios_test_flutter` target. Xcode 15 beta XCTest framework headers contained unguarded usage of iOS 17 API. This bug resulted in engine build failures. This was fixed in a later XCTest framework release. ``` /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:30: error: 'XCUIAccessibilityAuditType' is only available on iOS 17.0 or newer [-Werror,-Wunguarded-availability-new] 19 | typedef NS_OPTIONS(uint64_t, XCUIAccessibilityAuditType) { | ^ /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:30: note: 'XCUIAccessibilityAuditType' has been marked as being introduced in iOS 17.0 here, but the deployment target is iOS 13.0.0 /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:9: note: annotate anonymous enum with an availability attribute to silence this warning 19 | typedef NS_OPTIONS(uint64_t, XCUIAccessibilityAuditType) { | ^ /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:383:34: note: expanded from macro 'NS_OPTIONS' 383 | #define NS_OPTIONS(_type, _name) CF_OPTIONS(_type, _name) | ^ /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:155:96: note: expanded from macro 'CF_OPTIONS' 155 | #define CF_OPTIONS(_type, _name) __attribute__((availability(swift,unavailable))) _type _name; enum __CF_OPTIONS_ATTRIBUTES : _name | ``` Issue: flutter/flutter#128958 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Configuration menu - View commit details
-
Copy full SHA for 7643ef1 - Browse repository at this point
Copy the full SHA 7643ef1View commit details -
Roll Dart SDK from 625e0a9cb67a to 05d58364e92f (1 revision) (#56688)
https://dart.googlesource.com/sdk.git/+log/625e0a9cb67a..05d58364e92f 2024-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-160.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Configuration menu - View commit details
-
Copy full SHA for c9a965c - Browse repository at this point
Copy the full SHA c9a965cView commit details -
Update emulator definitions version to latest available from chrome i…
…nfra (#56313) Update to the latest definitions of emulator configurations. (except x86/api28 see b/379736755) Specifically to past https://crrev.com/c/5908894 which added `gpu_mode: "swangle_indirect"` to the api 35 proto. This should help with emulator stability on versions past android 13. Related to b/371020223 Research notes / my findings for how this system works at go/flutter-android-ci-emulator
Configuration menu - View commit details
-
Copy full SHA for 10dc07b - Browse repository at this point
Copy the full SHA 10dc07bView commit details
Commits on Nov 19, 2024
-
[Impeller] use sync fence for image uploads. (#56609)
Fixes flutter/flutter#158963 If the GLES version is at least 3, then we can attach a sync fence to the texture gles object. If this operation succeeds, then we can use gl.Flush instad of gl.Finish. Then, when binding the texture - if a sync fence is present we wait and then remove the fence.
Jonah Williams authoredNov 19, 2024 Configuration menu - View commit details
-
Copy full SHA for c1b0e18 - Browse repository at this point
Copy the full SHA c1b0e18View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 878f593802e1...c1b0e18a70b3