Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 878f593802e1
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c1b0e18a70b3
Choose a head ref
  • 13 commits
  • 63 files changed
  • 8 contributors

Commits on Nov 18, 2024

  1. Roll Skia from 0b74d5c3eb4f to 0d24bd3268ef (1 revision) (#56680)

    https://skia.googlesource.com/skia.git/+log/0b74d5c3eb4f..0d24bd3268ef
    
    2024-11-18 borenet@google.com Revert "[infra] Remove P400 jobs from CQ"
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b79353d View commit details
    Browse the repository at this point in the history
  2. Flutter views can gain focus (#54985)

    I am unsure why the `tabindex` was removed when semantics were enabled. It seems this change was made without a clear explanation (by me). This PR shouldn't cause any issues as Flutter Views already have a tabindex, we're not adding a new one. This change is necessary because the semantics text strategy refocuses the view on deactivation, requiring the Flutter view to be focusable.
    
    ThIs PR is a requirement to enable #54966. 
    
    flutter/flutter#153022
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    tugorez authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    dec7eb9 View commit details
    Browse the repository at this point in the history
  3. Roll Skia from 0d24bd3268ef to b79e71223284 (1 revision) (#56683)

    https://skia.googlesource.com/skia.git/+log/0d24bd3268ef..b79e71223284
    
    2024-11-18 vigneshv@google.com SkCrabbyAvifCodec: Compute fGainmapMathColorSpace
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    03af645 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    68ef504 View commit details
    Browse the repository at this point in the history
  5. iOS,macOS: Enable ARC in flutter_cflags_objc[c] (#56685)

    Enables the `-fobjc-arc` compiler flag for Objective-C and Objective-C++
    translation units.
    
    Eliminates the flutter_cflags_objc[c]_arc settings, since they're now
    redundant.
    
    All Obj-C/Obj-C++ code in our codebase has now been migrated to ARC.
    
    Issue: flutter/flutter#137801
    cbracken authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    e1a38ed View commit details
    Browse the repository at this point in the history
  6. Update the Skia build scripts for a refactoring of the Fontconfig fon…

    …t manager (#56684)
    
    Skia is reorganizing some font managers, and the Flutter engine's build scripts need to match the changes made to Skia.
    
    See https://skia-review.googlesource.com/c/skia/+/915316
    jason-simmons authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4573b0c View commit details
    Browse the repository at this point in the history
  7. Roll Skia from b79e71223284 to 492e8347d7a4 (2 revisions) (#56687)

    https://skia.googlesource.com/skia.git/+log/b79e71223284..492e8347d7a4
    
    2024-11-18 maxhudnell@google.com add triangulated gradient effect
    2024-11-18 vigneshv@google.com SkCrabbyAvifCodec: Add RGB565 support
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jimgraham@google.com,michaelludwig@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    635dee8 View commit details
    Browse the repository at this point in the history
  8. Extract TestGLContext to separate translation unit (#56647)

    For consistency with the Test.*Context classes for other backends, which live in their own implementation file with their own header, extract TestEGLContext to its own header and TU so that in cases where only a TestEGLContext is required (e.g. EmbedderTestBackingStoreProducerGL), we don't need to include all the various test GL surface classes as well.
    
    GetEGLError is used by both TestEGLContext and the TestGLSurface classes, so moves to its own utils file.
    
    No tests because this is a refactoring with no semantic changes, and the code itself is test code.
    
    Issue: flutter/flutter#158998
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7f2d56b View commit details
    Browse the repository at this point in the history
  9. [skwasm] Use displayWidth/displayHeight instead of codedWidth/`…

    …codedHeight` (#56686)
    
    This addresses flutter/flutter#159088
    
    If the image is rotated in its exif data, the coded width/height may differ from the display width/height. It's important to use the display width/height so that `texImage2D` does the right thing with the `VideoFrame`.
    eyebrowsoffire authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b9b57a9 View commit details
    Browse the repository at this point in the history
  10. iOS: Eliminate unguarded-availability opt-out (#56689)

    Eliminates the opt-out of `-Wunguarded-availability-new` in the `ios_test_flutter` target.
    
    Xcode 15 beta XCTest framework headers contained unguarded usage of iOS 17 API. This bug resulted in engine build failures.
    
    This was fixed in a later XCTest framework release.
    
    ```
    /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:30: error: 'XCUIAccessibilityAuditType' is only available on iOS 17.0 or newer [-Werror,-Wunguarded-availability-new]
       19 | typedef NS_OPTIONS(uint64_t, XCUIAccessibilityAuditType) {
          |                              ^
    /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:30: note: 'XCUIAccessibilityAuditType' has been marked as being introduced in iOS 17.0 here, but the deployment target is iOS 13.0.0
    /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/Library/Frameworks/XCTest.framework/Headers/XCUIAccessibilityAuditTypes.h:19:9: note: annotate anonymous enum with an availability attribute to silence this warning
       19 | typedef NS_OPTIONS(uint64_t, XCUIAccessibilityAuditType) {
          |         ^
    /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:383:34: note: expanded from macro 'NS_OPTIONS'
      383 | #define NS_OPTIONS(_type, _name) CF_OPTIONS(_type, _name)
          |                                  ^
    /Applications/Xcode_15-beta.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.0.sdk/System/Library/Frameworks/CoreFoundation.framework/Headers/CFAvailability.h:155:96: note: expanded from macro 'CF_OPTIONS'
      155 | #define CF_OPTIONS(_type, _name) __attribute__((availability(swift,unavailable))) _type _name; enum __CF_OPTIONS_ATTRIBUTES : _name
          |
    ```
    
    Issue: flutter/flutter#128958
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7643ef1 View commit details
    Browse the repository at this point in the history
  11. Roll Dart SDK from 625e0a9cb67a to 05d58364e92f (1 revision) (#56688)

    https://dart.googlesource.com/sdk.git/+log/625e0a9cb67a..05d58364e92f
    
    2024-11-18 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-160.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,jimgraham@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    c9a965c View commit details
    Browse the repository at this point in the history
  12. Update emulator definitions version to latest available from chrome i…

    …nfra (#56313)
    
    Update to the latest definitions of emulator configurations.  (except x86/api28 see b/379736755)
    Specifically to past  https://crrev.com/c/5908894 which added `gpu_mode: "swangle_indirect"` to the api 35 proto. This should help with emulator stability on versions past android 13. 
    Related to  b/371020223
    Research notes / my findings for how this system works at go/flutter-android-ci-emulator
    reidbaker authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    10dc07b View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. [Impeller] use sync fence for image uploads. (#56609)

    Fixes flutter/flutter#158963
    
    If the GLES version is at least 3, then we can attach a sync fence to the texture gles object. If this operation succeeds, then we can use gl.Flush instad of gl.Finish. Then, when binding the texture - if a sync fence is present we wait and then remove the fence.
    Jonah Williams authored Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c1b0e18 View commit details
    Browse the repository at this point in the history
Loading