Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 78c1ad249b57
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 305890ab2580
Choose a head ref
  • 7 commits
  • 54 files changed
  • 6 contributors

Commits on Sep 21, 2023

  1. Remove linux fuchsia from recipes cq. (#46153) 

    With some recent changes led builds can only run if they use -real-build. The migration of fuchsia builds to use -real-build as involved as migrating it to engine v2 and we are implementing the second one.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @godofredoc
    godofredoc authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    0dbdd85 View commit details
    Browse the repository at this point in the history

  2. Move git_repo_tools and process_fakes outside of clang_tidy. (#… 

    …46017)

Closes flutter/flutter#134988.
    @matanlurey
    matanlurey authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    c0ee5f0 View commit details
    Browse the repository at this point in the history

  3. Revert "[web] fix clicks on merged semantic nodes (#43620)" (#46067) 

    This reverts commit 0c1de9b.

The commit caused flutter/flutter#134842. I'm going to try again, this time accounting for nested clickables/tappables.
    @yjbanov
    yjbanov authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    902ab57 View commit details
    Browse the repository at this point in the history

  4. Reland: Enforce the rule of calling FlutterView.Render (#45300) (#45555) 

    This PR relands #45300 which was reverted in #45525 due to hanging on a windows startup test. The culprit test still calls `FlutterView.render` in the illegal way, which is ignored, causing no frame being ever produced. This has been fixed in flutter/flutter#134245. I've also searched through the framework repo for `render(` to ensure there are no other cases.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @dkwingsmt
    dkwingsmt authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    4b4a76b View commit details
    Browse the repository at this point in the history

  5. More Clang Tidy --fix[es] to header files (#46151) 

    More work towards flutter/flutter#134969.

I decided not to touch the `LOG_X` variables since they are just used in macro expansion.
    @matanlurey
    matanlurey authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    65c458b View commit details
    Browse the repository at this point in the history

  6. [Impeller] Use final cmd buffer to present drawable. (#46023) 

    If we're not running with a transaction then we don't need to block on waitUntilScheduled on any platform. I think this should always work, as the problems we had before were due to always using drawable present. But this helper method schedules the drawable presentation after the cmd buffer is scheduled - which is what we're doing with waitUntilScheduled anyway - just non blocking from our perspective.

Fixes flutter/flutter#131520
    Jonah Williams authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    981e8c9 View commit details
    Browse the repository at this point in the history

  7. Re-enable HardwareBuffer backed Platform Views on Android >= 29 (#46071)

    @johnmccutchan
    johnmccutchan authored Sep 21, 2023
    Configuration menu
    Copy the full SHA
    305890a View commit details
    Browse the repository at this point in the history
Loading