Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5f6dec8bd877
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: bb4ec2d7eb39
Choose a head ref
  • 4 commits
  • 18 files changed
  • 2 contributors

Commits on Apr 2, 2024

  1. Use fml::ScopedCleanupClosure instead of DeathRattle. (#51834) 

    Closes flutter/flutter#146105.

Originally when we authored these suites, `ScopedCleanupClosure` disallowed move-semantics, but that was fixed in #45772, so there is no reason to have a copy of these in different tests.

/cc @jonahwilliams
    @matanlurey
    matanlurey authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    0e84f61 View commit details
    Browse the repository at this point in the history

  2. Return an empty optional in HardwareBuffer::GetSystemUniqueID if the … 

    …underlying NDK API is unavailable (#51839)
    @jason-simmons
    jason-simmons authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    84c258a View commit details
    Browse the repository at this point in the history

  3. Run DrawSolidBlueScreenTest 20x in a row in bringup (up from 5x) (#… 

    …51850)

I'm hoping this increases the chance of a flake by ~4x, as that would help me debug flutter/flutter#145988.

Also removed `--verbose`, which wasn't valuable (just made the "filtered" logs harder to read).
    @matanlurey
    matanlurey authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c1aa1d5 View commit details
    Browse the repository at this point in the history

  4. Add an engine switch that controls whether the platform isolate API i… 

    …s available. (#51784)

Platform isolates are currently supported only on Android and iOS.

See flutter/flutter#136314
    @jason-simmons
    jason-simmons authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bb4ec2d View commit details
    Browse the repository at this point in the history
Loading