Comparing changes

https://dart.googlesource.com/sdk.git/+log/78174b41ab0f..7a5e410f982e 2024-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-37.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,matanl@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://dart.googlesource.com/sdk.git/+log/7a5e410f982e..db99af14c4bc 2024-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-38.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…#43101) Fixes flutter/flutter#129085 ## Changes to `FlutterMouseCursorPlugin` - `none` cursor is not handled by hiding the cursor anymore. That was too big of a hammer as it also affects other views (and platform views). Instead empty cursor is created from empty `NSImage`. - Cursor plugin now notifies the engine when cursor has changed. The engine forwards the change to last `FlutterView` that handled mouse event. This is necessary because on occasion `FlutterView` needs to be able to restore cursor without framework being involved. ## Preventing PlatformView from changing cursor when it is obscured by Flutter Content. Generally in Cocoa cursor changes are done as response to `mouseMoved` event, which is driven by a `NSTrackingArea`. The issue here is that this is not affected by hit testing and tracking areas form a hierarchy parallel to view hierarchy and are not affected by being obscured by another view (or tracking area). This means that platform view will receive `mouseMoved` event even when is obscured by Flutter content. To work around this, the mutator view puts a tracking area above platform view, which means it gets the mouseMove event first, and when it decides that mouse is over Flutter content, it will prevent platform view from changing the cursor for the rest of RunLoop turn (see `NSCursor+IgnoreChange`). ## Actual hit testing This part is rather straightforward, the area where FlutterContent obscures mutator view is provided to the mutator view, which will return `nil` from `hitTest:` when the point is in the obscured area. ## Example of hit testing https://github.com/flutter/engine/assets/96958/bbac0cfd-8c44-44d3-addd-921c91a8a539 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I signed the [CLA]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

…#51986)" (#51989) Reverts: #51986 Initiated by: zanderso Reason for reverting: flutter/flutter#146506 Original PR Author: skia-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: https://dart.googlesource.com/sdk.git/+log/7a5e410f982e..db99af14c4bc 2024-04-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-38.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC chinmaygarde@google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

When recreating this `unique_ptr`, we need to ensure it matches the type in `Surface::renderPictures` which is released. See here: ``` std::unique_ptr<sk_sp<SkPicture>[]> picturePointers = std::make_unique<sk_sp<SkPicture>[]>(count); for (int i = 0; i < count; i++) { picturePointers[i] = sk_ref_sp(pictures[i]); } // Releasing picturePointers here and will recreate the unique_ptr on the // other thread See surface_renderPicturesOnWorker skwasm_dispatchRenderPictures(_thread, this, picturePointers.release(), count, callbackId); ```

…51980)" (#51990) This reverts commit 6dc91bf. Reverting for flutter/flutter#146506

The engine has ostream conversions for most Skia objects, but none of the test files include the files where they are defined. Adding the include file to the `layer_test.h` file will include them on any file which does unit testing on the engine layers.

Fixes flutter/flutter#143531 Also fixes a random typo I found TODO to test this: -test the framework against this as well, probably with a dummy PR changing the engine commit to my branch if this is possible -figure out if the old embedding is used in g3 at all -~figure out exactly what the ShimPluginRegistry/ShimRegistrar are doing, and if fully deleting them was right~ (see #51229 (comment)) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Reverts: #51229 Initiated by: gmackall Reason for reverting: blocking engine->framework roll (I missed some framework code referencing the v1 embedding). Original PR Author: gmackall Reviewed By: {matanlurey, reidbaker} This change reverts the following previous change: Fixes flutter/flutter#143531 Also fixes a random typo I found ~TODO to test this~ (no more todo): -~test the framework against this as well, probably with a dummy PR changing the engine commit to my branch if this is possible~ not possible, made a best effort removal of framework code in flutter/flutter#144726. -~figure out if the old embedding is used in g3 at all~ removed all uses -~figure out exactly what the ShimPluginRegistry/ShimRegistrar are doing, and if fully deleting them was right~ (see #51229 (comment)) [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on Apr 9, 2024

This comparison is taking too long to generate.

Uh oh!