Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 55eefd5bd255
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2167a93c1a0
Choose a head ref
  • 2 commits
  • 4 files changed
  • 1 contributor

Commits on Jan 25, 2024

  1. Revert "[Impeller] round up subpass coverage when it is close to (and… 

    … smaller) than root pass size." (#50041)

Reverts #49925

This did not improve benchmarks: https://flutter-flutter-perf.skia.org/e/?queries=device_type%3DPixel_7_Pro%26sub_result%3D90th_percentile_frame_rasterizer_time_millis%26sub_result%3D99th_percentile_frame_rasterizer_time_millis%26sub_result%3Daverage_frame_rasterizer_time_millis%26sub_result%3Dworst_frame_rasterizer_time_millis%26test%3Dnew_gallery_impeller_old_zoom__transition_perf&selected=commit%3D38910%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dnew_gallery_impeller_old_zoom__transition_perf%252C

From follow up investigation: some of the routes hit this optimization, while some did not as the the bounds size seems to depend on the exact contents.
    @jonahwilliams
    jonahwilliams authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    184cc83 View commit details
    Browse the repository at this point in the history

  2. [Impeller] write vertices geometry data to host buffer. (#49741) 

    Now that host buffer writes go directly to device buffers, there is no advantage to creating dedicated device buffers for the vertices contents.

Fixes flutter/flutter#141202
    @jonahwilliams
    jonahwilliams authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    b2167a9 View commit details
    Browse the repository at this point in the history
Loading