Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5355c0b60e6e
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 86f269bd5261
Choose a head ref
  • 4 commits
  • 4 files changed
  • 4 contributors

Commits on Aug 19, 2024

  1. Changes DlColor to support wide gamut colors (#54473) 

    issue: flutter/flutter#127855
integration test: #54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with #54415 when it lands in #54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    93e5c81 View commit details
    Browse the repository at this point in the history

  2. [Impeller] account for negative scale in max basis xy. (#54630) 

    Otherwise we get funky negative scales that break tessellation.
    Jonah Williams authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    390cb99 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Reverts "Changes DlColor to support wide gamut colors (#54473)" (#54636) 

    Reverts: #54473
Initiated by: jonahwilliams
Reason for reverting: golden diffs like https://flutter-engine-gold.skia.org/detail?grouping=name%3Dimpeller_Play_AiksTest_BlendModeSrcAlphaLuminosity_OpenGLES%26source_type%3Dflutter-engine&digest=107ccd2cd1170746b1ffc4d31184e789 look incorrect, potentially an alpha issue
Original PR Author: gaaclarke

Reviewed By: {flar}

This change reverts the following previous change:
issue: flutter/flutter#127855
integration test: #54415

This is the engine side changes required for wide gamut framework support.  It changes the internal representation of DlColor to be floats.  It will be married with #54415 when it lands in #54567.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @auto-submit
    auto-submit[bot] authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    5c17e46 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from e65e02c50d66 to 30a00629e135 (3 revisions) (#54634) 

    https://skia.googlesource.com/skia.git/+log/e65e02c50d66..30a00629e135

2024-08-20 brianosman@google.com Reland "Guard division in luminosity blend against overflow"
2024-08-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from f8f75e8cc154 to b038f07b8faf (3 revisions)
2024-08-19 kschmi@microsoft.com Revert "Revert "Reland "Reduce size of linear SkMaskGamma LUT"""

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    86f269b View commit details
    Browse the repository at this point in the history
Loading