Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5064aeff00de
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 90c3ada3682c
Choose a head ref
  • 9 commits
  • 42 files changed
  • 5 contributors

Commits on Nov 16, 2023

  1. [canvaskit] Size the PictureRecorder when calling Scene.toImage (#48142)

    When calling `flatten()` to produce a `Picture` of a `Scene`, size the
    `PictureRecorder` to be the same size as the final image.
    
    Fixes flutter/flutter#138009
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    harryterkelsen authored Nov 16, 2023
    Configuration menu
    Copy the full SHA
    79f960a View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Roll Skia from 762d95ed65e0 to c7d2a4933dfa (1 revision) (#48159)

    https://skia.googlesource.com/skia.git/+log/762d95ed65e0..c7d2a4933dfa
    
    2023-11-16 jlavrova@google.com Emoji font resolution fix
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    fdfd452 View commit details
    Browse the repository at this point in the history
  2. Roll Dart SDK from 906f23c1cb20 to 12c5efc94edf (1 revision) (#48157)

    https://dart.googlesource.com/sdk.git/+log/906f23c1cb20..12c5efc94edf
    
    2023-11-16 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-144.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    85c1419 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    739b2fe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7f0d20d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f4cfc81 View commit details
    Browse the repository at this point in the history
  6. Only run systrace test on API 29+, avoid building scenario app for 28 (

    …#48163)
    
    The emulator tests I added yesterday are failing because the systrace python test script uses features introduced in API 29, which causes the `perfetto` invocation to fail.
    
    It's not essential that we run this test on lower API levels, so instead I'm making the script bail out in this case.
    
    Other than that, the shard seems to be consistently passing, so I'm removing bringup.
    dnfield authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    85dd1e4 View commit details
    Browse the repository at this point in the history
  7. Roll Skia from c7d2a4933dfa to c8ee25282849 (2 revisions) (#48164)

    https://skia.googlesource.com/skia.git/+log/c7d2a4933dfa..c8ee25282849
    
    2023-11-17 lovisolo@google.com [bazel] Housekeeper-PerCommit-GoLinters: Add errcheck step.
    2023-11-16 lovisolo@google.com [bazel] New task: Housekeeper-PerCommit-GoLinters.
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC brianosman@google.com,jonahwilliams@google.com,nicolettep@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b7bc807 View commit details
    Browse the repository at this point in the history
  8. Roll Dart SDK from 12c5efc94edf to 46e8b18047eb (1 revision) (#48168)

    https://dart.googlesource.com/sdk.git/+log/12c5efc94edf..46e8b18047eb
    
    2023-11-17 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-145.0.dev
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/dart-sdk-flutter-engine
    Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    90c3ada View commit details
    Browse the repository at this point in the history
Loading