Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4cc0b3dab001
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b08e1410a06a
Choose a head ref
  • 9 commits
  • 58 files changed
  • 6 contributors

Commits on Aug 3, 2023

  1. [Flutter GPU] Export symbols from engine, stub for testing on CI. (#4… 

    …4280)

Part of flutter/flutter#131346

Stubs a minimal test of the FFI utilities that `dart:ui` uses, but using
public symbols exported from the engine library. If this goes well, I'll
move the stuff from `dart:ui` into here and begin landing parts of the
API with test coverage.
    @bdero
    bdero authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a123723 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 8a377a9545b8 to 768050436c0a (1 revision) (#44320) 

    https://skia.googlesource.com/skia.git/+log/8a377a9545b8..768050436c0a

2023-08-03 johnstiles@google.com Remove or replace GCE Perf tests.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    e589d59 View commit details
    Browse the repository at this point in the history

  3. Re-Re-Land Support for rendering Android Platform Views into a Hardwa… 

    …reBuffer backed texture (#44326)

Introduce TextureRegistry.ImageTexture and related machinery.
Introduce ImageReaderPlatformViewRenderTarget.
Introduce HardwareBufferExternalTextureGL and related machinery.
NOTE: ImageReaderPlatformViewRenderTarget requires Android 26.

NOTE: This CL does not enable using ImageReaderPlatformViewRenderTarget
yet.

Related flutter/flutter#130892

---------

Co-authored-by: Jason Simmons <jsimmons@google.com>
    @johnmccutchan @jason-simmons
    johnmccutchan and jason-simmons authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0832dfa View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 768050436c0a to bd3ee535e246 (2 revisions) (#44327) 

    https://skia.googlesource.com/skia.git/+log/768050436c0a..bd3ee535e246

2023-08-03 johnstiles@google.com Eliminate DSLExpression.
2023-08-03 brianosman@google.com Disable implicit function declaration warning in microhttpd

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9522ce9 View commit details
    Browse the repository at this point in the history

  5. [ios]make the screenIfViewLoaded and windowSceneIfLoaded helpers reus… 

    …able (#44303)

The existing `screenIfViewLoaded` and `windowSceneIfLoaded` functions are private helpers of `FlutterViewController` class. This PR moves the logic to a category of the `UIViewController`, so it can be reused for any `UIViewController`s. 

*List which issues are fixed by this PR. You must list at least one issue.*

#43972 (comment)

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @hellohuanlin
    hellohuanlin authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    26b9d3b View commit details
    Browse the repository at this point in the history

  6. [Impeller] updated validation layers documentation (#44328) 

    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    9025bfb View commit details
    Browse the repository at this point in the history

  7. Roll Dart SDK from dcd09f5726b7 to e3d2b4a190aa (1 revision) (#44330) 

    https://dart.googlesource.com/sdk.git/+log/dcd09f5726b7..e3d2b4a190aa

2023-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-34.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b5a70db View commit details
    Browse the repository at this point in the history

  8. Roll Skia from bd3ee535e246 to 36072a994f11 (2 revisions) (#44329) 

    https://skia.googlesource.com/skia.git/+log/bd3ee535e246..36072a994f11

2023-08-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from e057bba499d3 to d8fdb68e5922 (1 revision)
2023-08-03 lovisolo@google.com [bazel] //gm/BazelGMRunner.cpp: Print successful/skipped/failed GM counts.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,jvanverth@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0a57c56 View commit details
    Browse the repository at this point in the history

  9. Add @keep annotations to avoid dead code elimination of classes only … 

    …referenced by JNI (#44337)

Missing piece
    @johnmccutchan
    johnmccutchan authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    b08e141 View commit details
    Browse the repository at this point in the history
Loading