Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 3e3be5e33bda
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 117d47aa3f88
Choose a head ref
  • 20 commits
  • 33 files changed
  • 11 contributors

Commits on Nov 7, 2023

  1. [Windows] Reduce warnings produced by unit tests (#47724)

    This PR contains no functional changes but improves existing unit tests to reduce the number of warnings output when the tests are ran:
    
    1. Replaced `ON_CALL` with `EXPECT_CALL` for expected method calls
    2. Added some missing mocks
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    loic-sharma authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    295a532 View commit details
    Browse the repository at this point in the history
  2. Promote fuchsia build v2 to prod. (#47729)

    The current failure in staging is because the service account does not have write access to the release bucket.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    godofredoc authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    111808f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3610cc9 View commit details
    Browse the repository at this point in the history
  4. Roll Skia from 030e21befbc9 to f91d39395e85 (6 revisions) (#47769)

    https://skia.googlesource.com/skia.git/+log/030e21befbc9..f91d39395e85
    
    2023-11-07 jvanverth@google.com Fix colorspace transform with multitexture color text.
    2023-11-07 nscobie@google.com Revert "Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr"
    2023-11-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from e98bb78ac013 to 4da518531bee
    2023-11-07 egdaniel@google.com [Graphite] Add support for SkTraceMemoryDump for gpu Resources.
    2023-11-07 michaelludwig@google.com [graphite] Skip calling getMostRecentDraw() for draws that don't need it for sorting
    2023-11-07 kjlubick@google.com Migrate many direct and indirect uses of SkFontMgr to use TestFontMgr
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b2ef1fa View commit details
    Browse the repository at this point in the history
  5. Remove Fuchsia Mac SDK from DEPS (#47700)

    Save infra capacity. Fuchsia commits 4 times a day, which can trigger a subsequent framework roll. Removing the Mac roller as it appears to be unused anymore.
    
    Skia config is in https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/774657
    Casey Hillers authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    a1bad07 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Include updated locations for dart third_party components into licens…

    …e ignore-list. (#47770)
    
    Incoming dart roll with
    https://dart.googlesource.com/sdk/+/4d308f39115a2969fb9908055b37a93969d4fc8d
    moves `runtime/third_parry` in dart to `third_party`, so license script
    ignore-list have to be updated to accommodate new location.
    
    Once the roll lands, old locations should be cleaned up from the
    ignore-list.
    aam authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a70369d View commit details
    Browse the repository at this point in the history
  2. Reverts "Promote fuchsia build v2 to prod." (#47779)

    Reverts #47729
    Initiated by: bdero
    This change reverts the following previous change:
    Original Description:
    The current failure in staging is because the service account does not have write access to the release bucket.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    auto-submit[bot] authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c8195b4 View commit details
    Browse the repository at this point in the history
  3. [testing] Extract StreamCapture test utility (#47774)

    Factors out an RAII-based class that can be used to capture std::cout, std::cerr, or technically any other std::ostream, though that's unlikely to be useful.
    
    This makes the logic reusable but more importantly, ensures the capture is cleaned up at the end of the test.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    cbracken authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5224cae View commit details
    Browse the repository at this point in the history
  4. Roll Skia from f91d39395e85 to 0f78e5f765d3 (1 revision) (#47776)

    https://skia.googlesource.com/skia.git/+log/f91d39395e85..0f78e5f765d3
    
    2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 565eac2306d8 to 969da898b476 (8 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    98eedd9 View commit details
    Browse the repository at this point in the history
  5. [macOS] Bail out of tests if engine not running (#47771)

    In engine tests where we require a running engine to proceed with the
    test, immediately fail if the engine isn't running rather than carrying
    on with the test. In most cases, the fixture test proceeds to block the
    main thread on a latch until it's released from the UI thread, so this
    results in quicker test failures.
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [ ] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I signed the [CLA].
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    cbracken authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b6acdc7 View commit details
    Browse the repository at this point in the history
  6. Fix narrowing conversion lint (#47740)

    Internally we have a lint that surfaces this as a warning. Googlers, please refer to go/al-rule/NarrowingConversion.
    
    Related: b/309552840
    
    When we do:
    ```
    coords.toolMajor = (float) (double) coordsList.get(3) * density;
    ```
    
    `coordsList.get(3)` is casted to a `double`, then a `float`, before the multiplication happens. 
    
    I don't think this is intentional. The intention of the code here seems to be:
    
    - Cast to a `double`: `coordsList` is a `List<Object>` so the cast narrows the value
    - Cast to a `float`: To fit the resulting value into [`coords.toolMajor`](https://developer.android.com/reference/android/view/MotionEvent.PointerCoords#toolMajor), which is a `float`.
    
    As such, add parenthesis to address this.
    
    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    jiahaog authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5833714 View commit details
    Browse the repository at this point in the history
  7. Roll Fuchsia Linux SDK from VcFEJiUUTYwkhEAlJ... to sD8HRA4JmXczujkqO…

    …... (#47785)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
    Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3954624 View commit details
    Browse the repository at this point in the history
  8. Roll Skia from 0f78e5f765d3 to b4fa927468e6 (1 revision) (#47788)

    https://skia.googlesource.com/skia.git/+log/0f78e5f765d3..b4fa927468e6
    
    2023-11-08 sunnyps@chromium.org graphite: Fixes for enabling storage buffers for Dawn backend
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    bd15e8f View commit details
    Browse the repository at this point in the history
  9. [web] fix clicks on merged semantic nodes (attempt #2) (#47360)

    This relands #43620 with a fix for nested tappable nodes. The first PR introduced this regression: flutter/flutter#134842.
    
    This PR includes the original PR and a fix for the regression. The fix is to call `stopPropagation` on the "click" event so that it is not handled by the ancestor if the child has already decided to send a `SemanticsAction.tap` to the framework. This ensures that there cannot be more than one `SemanticsAction.tap` sent to the framework.
    
    Fixes flutter/flutter#134842
    yjbanov authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    eb3b2bb View commit details
    Browse the repository at this point in the history
  10. Reverts "Remove Fuchsia Mac SDK from DEPS" (#47791)

    Reverts #47700
    Initiated by: zanderso
    This change reverts the following previous change:
    Original Description:
    Save infra capacity. Fuchsia commits 4 times a day, which can trigger a subsequent framework roll. Removing the Mac roller as it appears to be unused anymore.
    
    Skia config is in https://skia-review.googlesource.com/c/skia-autoroll-internal-config/+/774657
    auto-submit[bot] authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9250de9 View commit details
    Browse the repository at this point in the history
  11. [Impeller] Add Rect::GetNormalizingTransform to handle UV coordinate …

    …conversion (#47775)
    
    Three places in the code were manually computing the UV coordinates relative to a texture coverage rectangle while also transforming the points. This change will make it easier both to compute the UV conversion matrix and also to consolidate it with the transform that was already being applied to streamline the total computations.
    flar authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b5a151f View commit details
    Browse the repository at this point in the history
  12. Roll Skia from b4fa927468e6 to f3d250126ba9 (1 revision) (#47793)

    https://skia.googlesource.com/skia.git/+log/b4fa927468e6..f3d250126ba9
    
    2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5c95af798ba4 to 4a62a93e27d9 (1 revision)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    77d1b4b View commit details
    Browse the repository at this point in the history
  13. Roll Skia from f3d250126ba9 to fce71a80b0a2 (1 revision) (#47796)

    https://skia.googlesource.com/skia.git/+log/f3d250126ba9..fce71a80b0a2
    
    2023-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0584ffd8fbdd to a494c1d6c813 (6 revisions)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    692f131 View commit details
    Browse the repository at this point in the history
  14. [macOS] Clean up resources in ViewController tests (#47792)

    Wraps all FlutterViewController tests in an autorelease pool to ensure
    resources are cleaned up.
    
    Adds a MockFlutterEngineTest subclass of AutoreleasePoolTest that
    creates an OCPartialMock FlutterEngine and shuts it down at the end of
    the test. Previously we were not shutting down any FlutterEngine
    instances we allocated, resulting in potentially thousands of threads
    and graphics contexts being allocated.
    
    Prior to this change, running these tests via:
    
        ../out/host_debug_unopt_arm64/flutter_desktop_darwin_unittests \
            --gtest_filter='FlutterViewController.*' --gtest_repeat=1000
    
    resulted in test failures and sometimes segfaults. This ensures
    resources are cleaned up
    
    Eventually all unit tests should configure their FlutterEngine via
    either FlutterEngineTest (which should be an AutoreleasePoolTest) or
    MockFlutterEngineTest, and the CreateMockFlutterEngine function moved to
    a static used in the implementation of these.
    
    Issue: flutter/flutter#104789
    Issue: flutter/flutter#127441
    Issue: flutter/flutter#124840
    
    ## Pre-launch Checklist
    
    - [x] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [x] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [x] I read and followed the [Flutter Style Guide] and the [C++,
    Objective-C, Java style guides].
    - [x] I listed at least one issue that this PR fixes in the description
    above.
    - [x] I added new tests to check the change I am making or feature I am
    adding, or the PR is [test-exempt]. See [testing the engine] for
    instructions on writing and running engine tests.
    - [x] I updated/added relevant documentation (doc comments with `///`).
    - [x] I signed the [CLA].
    - [x] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [C++, Objective-C, Java style guides]:
    https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    [testing the engine]:
    https://github.com/flutter/flutter/wiki/Testing-the-engine
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    cbracken authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e687d57 View commit details
    Browse the repository at this point in the history
  15. Roll Skia from fce71a80b0a2 to a4cce5236dcf (1 revision) (#47807)

    https://skia.googlesource.com/skia.git/+log/fce71a80b0a2..a4cce5236dcf
    
    2023-11-08 johnstiles@google.com Remove reference to skcms_internal.h
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/skia-flutter-autoroll
    Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    skia-flutter-autoroll authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    117d47a View commit details
    Browse the repository at this point in the history
Loading