Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1b20752e2a63
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f8961d203039
Choose a head ref
  • 6 commits
  • 58 files changed
  • 6 contributors

Commits on Nov 7, 2023

  1. [Impeller] Add support for specialization constants redux. (#47678) 

    Reland of #47432

Also includes:
  * #47617
  * #47637
  
Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

----

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes flutter/flutter#136210
Fixes flutter/flutter#119357
    Jonah Williams authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    be43db3 View commit details
    Browse the repository at this point in the history

  2. Don't use Skia BUILD.gn files (#47677) 

    The new `BUILD.gn` files in the Engine tree can't go under
`build/secondary` because Skia still has its own, and they'd be selected
first. So, this PR puts the new `BUILD.gn` files under `flutter/skia`.
    @zanderso
    zanderso authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    64d5af2 View commit details
    Browse the repository at this point in the history

  3. [ios] making objective-C smart pointers support ARC (#47612) 

    Moving the implementation from https://codereview.chromium.org/1855483004 into the code base, including:

- scoped_nsobject, scoped_nsprotocol, scoped_block will support both mrc and arc
- Added parent class scoped_typeref for shared code between scoped_block and scoped_nsobject
- moving OwnershipPolicy to its own file

The implementation of the smart pointers are almost identical to https://codereview.chromium.org/1855483004 besides some syntax preference differences between chromium and flutter.

This PR also migrated [VsyncWaiterIosTest.mm](https://github.com/flutter/engine/pull/47612/files#diff-c98ce1a2aca65c29bbc444523b66921a53ecce5ff39a420b4eda7dbfe8ca1cc7) to ARC with scoped_nsobject

fixes flutter/flutter#137802

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    Chris Yang authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    cf3473b View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 62fc1374cc5d to 030e21befbc9 (2 revisions) (#47756) 

    https://skia.googlesource.com/skia.git/+log/62fc1374cc5d..030e21befbc9

2023-11-07 jamesgk@google.com [viewer] Add angle mtl backend
2023-11-07 robertphillips@google.com [graphite] Add ProtectedUtils for Graphite

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,brianosman@google.com,fmalita@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5f5288f View commit details
    Browse the repository at this point in the history

  5. [Impeller] added tests for matrices (#47754) 

    [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @gaaclarke
    gaaclarke authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    04dba37 View commit details
    Browse the repository at this point in the history

  6. Reverts "[Impeller] Add support for specialization constants redux." (#… 

    …47762)

Reverts #47678
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Reland of #47432

Also includes:
  * #47617
  * #47637
  
Fixes the performance on iOS by removing blocking on compilation of shaders. From local testing this has identical before/after numbers. Additional, ensures that we don't unecessarily specialize vertex shaders and notes this restriction in the documentation.

----

Adds support for Specialization constants to Impeller for our usage in the engine. A motivating example has been added in the impeller markdown docs.

Fixes flutter/flutter#136210
Fixes flutter/flutter#119357
    @auto-submit
    auto-submit[bot] authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    f8961d2 View commit details
    Browse the repository at this point in the history
Loading