Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0ce67714ce4c
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: baebb4eb7e04
Choose a head ref
  • 11 commits
  • 13 files changed
  • 3 contributors

Commits on Apr 30, 2024

  1. Roll Skia from 8f2d039e1190 to 77350e051f71 (1 revision) (#52460) 

    https://skia.googlesource.com/skia.git/+log/8f2d039e1190..77350e051f71

2024-04-30 jvanverth@google.com Fix offscreen size in Viewer for some GMs.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    424a963 View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 77350e051f71 to 85ec65ecd5ec (2 revisions) (#52464) 

    https://skia.googlesource.com/skia.git/+log/77350e051f71..85ec65ecd5ec

2024-04-30 johnstiles@google.com Simplify binary search in tessellate_stroked_curve.
2024-04-30 johnstiles@google.com Use dot product when computing distance field gradients.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3cb398a View commit details
    Browse the repository at this point in the history

  3. Roll Dart SDK from 7a517de88964 to 3f649c97a08c (1 revision) (#52465) 

    https://dart.googlesource.com/sdk.git/+log/7a517de88964..3f649c97a08c

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-115.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    b397b10 View commit details
    Browse the repository at this point in the history

  4. Roll Skia from 85ec65ecd5ec to 30aaaef0390d (4 revisions) (#52466) 

    https://skia.googlesource.com/skia.git/+log/85ec65ecd5ec..30aaaef0390d

2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from f83e07df2219 to 4a3a57f4bb79
2024-04-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 09d0317bc33e to 9384550810a5 (10 revisions)
2024-04-30 kjlubick@google.com Tweak harfbuzz dep for legacy Bazel build
2024-04-30 bwils@google.com Run prettier on all sample skotties

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    55da126 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from 30aaaef0390d to a6bc04f984d2 (1 revision) (#52471) 

    https://skia.googlesource.com/skia.git/+log/30aaaef0390d..a6bc04f984d2

2024-04-30 kjlubick@google.com Escape unicode sequence

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    3dc46f2 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Roll Dart SDK from 3f649c97a08c to c88854d4282c (1 revision) (#52475) 

    https://dart.googlesource.com/sdk.git/+log/3f649c97a08c..c88854d4282c

2024-04-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-116.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 1, 2024
    Configuration menu
    Copy the full SHA
    14f2e8c View commit details
    Browse the repository at this point in the history

  2. [skwasm] Change default FilterQuality to None for image shaders. (#… 

    …52468)

This brings the behavior in line with the CanvasKit renderer, which also uses `None` for the default image shader quality.

I added a few unit tests to cover different filter qualities. It turns out, there is a skia issue that manifests both in CanvasKit and Skwasm when a lazy image is rendered with medium quality. See https://g-issues.skia.org/issues/338095525
    @eyebrowsoffire
    eyebrowsoffire authored May 1, 2024
    Configuration menu
    Copy the full SHA
    21ae0cc View commit details
    Browse the repository at this point in the history

  3. [Impeller] Document the EGL toolkit. (#52469) 

    No change in functionality. Just adds docs.
    @chinmaygarde
    chinmaygarde authored May 1, 2024
    Configuration menu
    Copy the full SHA
    f763ef1 View commit details
    Browse the repository at this point in the history

  4. Roll Dart SDK from c88854d4282c to d946408c559a (1 revision) (#52476) 

    https://dart.googlesource.com/sdk.git/+log/c88854d4282c..d946408c559a

2024-05-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-117.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 1, 2024
    Configuration menu
    Copy the full SHA
    b9389a9 View commit details
    Browse the repository at this point in the history

  5. Roll Skia from a6bc04f984d2 to 5f4ebd628994 (1 revision) (#52478) 

    https://skia.googlesource.com/skia.git/+log/a6bc04f984d2..5f4ebd628994

2024-05-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 690f568c5a84 to 816f6abb4c9a (11 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 1, 2024
    Configuration menu
    Copy the full SHA
    67179b4 View commit details
    Browse the repository at this point in the history

  6. Roll Fuchsia Linux SDK from HP2saK9sVOtKvpquC... to PIHl-e41i3mzbriG1… 

    …... (#52480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored May 1, 2024
    Configuration menu
    Copy the full SHA
    baebb4e View commit details
    Browse the repository at this point in the history
Loading