Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 08f9be3ab284
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0b42657a184e
Choose a head ref
  • 2 commits
  • 11 files changed
  • 2 contributors

Commits on Jul 30, 2024

  1. Reverts "Do not disable partial repaint based on thread merging state (… 

    …#54219)" (#54230)

Reverts: #54219
Initiated by: jonahwilliams
Reason for reverting: incorrect rendering on last frame after platform view is removed.
Original PR Author: knopp

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
Currently we force full repaint when thread merging is detected, but that is not a good way to determine whether platform view is in hierarchy when thread merging is no longer needed. Alternative solution here makes the PlatformViewLayer  force full repaint when diffing.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
    @auto-submit
    auto-submit[bot] authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0d2fd7a View commit details
    Browse the repository at this point in the history

  2. Roll Skia from 4e31906b6312 to e8fb6f320da0 (5 revisions) (#54229) 

    https://skia.googlesource.com/skia.git/+log/4e31906b6312..e8fb6f320da0

2024-07-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0ce5411a16fa to 51742b289ba3 (5 revisions)
2024-07-30 nathanasanchez@google.com [SkSL] Remove loadFloatBuffer intrinsic
2024-07-30 nathanasanchez@google.com [Graphite] Change module functions to take array parameters
2024-07-30 nathanasanchez@google.com [SkSL] Add a specialization in a call test
2024-07-30 johnstiles@google.com Reland "Move most KnownRuntimeEffects into the sksl_rt_shader module."

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0b42657 View commit details
    Browse the repository at this point in the history
Loading