Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 071e1fb21c7a
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 488876ed26c6
Choose a head ref
  • 5 commits
  • 24 files changed
  • 5 contributors

Commits on Jun 9, 2023

  1. Platform channel for predictive back (#39208) 

    Adds a platform channel method for enabling/disabling Android's predictive back feature.
    @justinmc
    justinmc authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ff66711 View commit details
    Browse the repository at this point in the history

  2. [Impeller] Makes validation layers flag work for android (#42625) 

    This builds and links in the validation layers for android. They then
can be turned on or off with a manifest field.

fixes flutter/flutter#123788
depends on flutter/buildroot#741

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
    @gaaclarke
    gaaclarke authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    06d0adb View commit details
    Browse the repository at this point in the history

  3. [Impeller] add explicit VMA flush to device memory writes. (#42685) 

    According to my read of the documentation for VMA/Vulkan allocation docs, setting VK_MEMORY_PROPERTY_HOST_COHERENT_BIT means we shouldn't need to flush the memory. nevertheless, this fixes the corruption of host buffers observed in flutter/flutter#124040

Fixes flutter/flutter#124040

> VK_MEMORY_PROPERTY_HOST_COHERENT_BIT bit specifies that the host cache management commands [vkFlushMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkFlushMappedMemoryRanges.html) and [vkInvalidateMappedMemoryRanges](https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/vkInvalidateMappedMemoryRanges.html) are not needed to flush host writes to the device or make device writes visible to the host, respectively.

����
    @jonahwilliams
    jonahwilliams authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a2f040e View commit details
    Browse the repository at this point in the history

  4. [Impeller] Add CPU implementations for all color filters (#42692) 

    Part of flutter/flutter#127232.

Adds a CPU implementation for ColorMatrix and the color space
conversions. Also changes the blend signature for consistency.

These will be necessary to make the mask blur fast path continue working
in the presence of color filters. In general, we can use these to
eliminate a needlessly expensive image-based color filter for the
non-image color sources.
    @bdero
    bdero authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    35e14c5 View commit details
    Browse the repository at this point in the history

  5. Roll ANGLE from a185cb8c8924 to 3e4f4caebcb0 (2 revisions) (#42701) 

    https://chromium.googlesource.com/angle/angle.git/+log/a185cb8c8924..3e4f4caebcb0

2023-06-09 romanl@google.com Tests: reduce load on perf bots by collecting less data
2023-06-09 romanl@google.com Tests: disable TraceTest.respawnables on native

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-flutter-engine
Please CC flutter-engine@google.com,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in ANGLE: http://anglebug.com/new
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    @skia-flutter-autoroll
    skia-flutter-autoroll authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    488876e View commit details
    Browse the repository at this point in the history
Loading