Vulkan:Disable FramebufferVk cache on Apple

Currently hitting a crash on Apple so disabling FramebufferVk cache.

Bug: angleproject:4442
Change-Id: I3824252210aeeaf9919c8d17730395b394a50862
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2080661
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Tobin Ehlis <tobine@google.com>

Author: tobine

include/platform/FeaturesVk.h

@@ -252,6 +252,11 @@ struct FeaturesVk : FeatureSetBase
                                        FeatureCategory::VulkanFeatures,
                                        "Enable Android pre-rotation for landscape applications",
                                        &members, "http://anglebug.com/3502"};
+
+    // Cache FramebufferVk objects. Currently hitting a bug on Apple: http://anglebug.com/4442
+    Feature enableFramebufferVkCache = {
+        "enable_framebuffer_vk_cache", FeatureCategory::VulkanFeatures,
+        "Enable FramebufferVk objects to be cached", &members, "http://anglebug.com/4442"};
 };
 
 inline FeaturesVk::FeaturesVk()  = default;

src/libANGLE/renderer/vulkan/FramebufferVk.cpp

@@ -1177,8 +1177,16 @@ angle::Result FramebufferVk::getFramebuffer(ContextVk *contextVk, vk::Framebuffe
     auto iter = mFramebufferCache.find(mCurrentFramebufferDesc);
     if (iter != mFramebufferCache.end())
     {
-        *framebufferOut = &iter->second.getFramebuffer();
-        return angle::Result::Continue;
+        if (contextVk->getRenderer()->getFeatures().enableFramebufferVkCache.enabled)
+        {
+            *framebufferOut = &iter->second.getFramebuffer();
+            return angle::Result::Continue;
+        }
+        else
+        {
+            // When cache is off just release previous entry, it will be recreated below
+            iter->second.release(contextVk);
+        }
     }
     vk::RenderPass *compatibleRenderPass = nullptr;
     ANGLE_TRY(contextVk->getCompatibleRenderPass(mRenderPassDesc, &compatibleRenderPass));

src/libANGLE/renderer/vulkan/RendererVk.cpp

@@ -1649,6 +1649,9 @@ void RendererVk::initFeatures(DisplayVk *displayVk, const ExtensionNameList &dev
     // Pre-rotation support is not fully ready to be enabled.
     ANGLE_FEATURE_CONDITION((&mFeatures), enablePreRotateSurfaces, false);
 
+    // Currently disable FramebufferVk cache on Apple: http://anglebug.com/4442
+    ANGLE_FEATURE_CONDITION((&mFeatures), enableFramebufferVkCache, !IsApple());
+
     angle::PlatformMethods *platform = ANGLEPlatformCurrent();
     platform->overrideFeaturesVk(platform, &mFeatures);