remove SkBitmapProcState::fInvKy

It's only used in asserts, and it's completely redundant with other
asserts based on fInvMatrix.

Change-Id: I150dc5b948e5703fff75bf857cabb173428b081f
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/249818
Reviewed-by: Mike Klein <mtklein@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

Author: Mike Klein

src/core/SkBitmapProcState.cpp

@@ -246,7 +246,6 @@ bool SkBitmapProcState::chooseProcs() {
 
     fInvProc            = SkMatrixPriv::GetMapXYProc(fInvMatrix);
     fInvSxFractionalInt = SkScalarToFractionalInt(fInvMatrix.getScaleX());
-    fInvKy              = SkScalarToFixed        (fInvMatrix.getSkewY());
 
     fAlphaScale = SkAlpha255To256(SkColorGetA(fPaintColor));
 
@@ -279,7 +278,6 @@ static void Clamp_S32_D32_nofilter_trans_shaderproc(const void* sIn,
                                                     int count) {
     const SkBitmapProcState& s = *static_cast<const SkBitmapProcState*>(sIn);
     SkASSERT(s.fInvMatrix.isTranslate());
-    SkASSERT(s.fInvKy == 0);
     SkASSERT(count > 0 && colors != nullptr);
     SkASSERT(kNone_SkFilterQuality == s.fFilterQuality);
 
@@ -342,7 +340,6 @@ static void Repeat_S32_D32_nofilter_trans_shaderproc(const void* sIn,
                                                      int count) {
     const SkBitmapProcState& s = *static_cast<const SkBitmapProcState*>(sIn);
     SkASSERT(s.fInvMatrix.isTranslate());
-    SkASSERT(s.fInvKy == 0);
     SkASSERT(count > 0 && colors != nullptr);
     SkASSERT(kNone_SkFilterQuality == s.fFilterQuality);
 
@@ -396,7 +393,6 @@ static void S32_D32_constX_shaderproc(const void* sIn,
                                       int count) {
     const SkBitmapProcState& s = *static_cast<const SkBitmapProcState*>(sIn);
     SkASSERT(s.fInvMatrix.isScaleTranslate());
-    SkASSERT(s.fInvKy == 0);
     SkASSERT(count > 0 && colors != nullptr);
     SkASSERT(1 == s.fPixmap.width());
 

src/core/SkBitmapProcState.h

@@ -76,7 +76,6 @@ struct SkBitmapProcState : public SkBitmapProcInfo {
     SkFixed             fFilterOneX;
     SkFixed             fFilterOneY;
 
-    SkFixed             fInvKy;             // chooseProcs
     uint16_t            fAlphaScale;        // chooseProcs
 
     /** Given the byte size of the index buffer to be passed to the matrix proc,

src/core/SkBitmapProcState_matrixProcs.cpp

@@ -140,7 +140,6 @@ template <unsigned (*tile)(SkFixed, int), unsigned (*extract_low_bits)(SkFixed,
 static void filter_scale(const SkBitmapProcState& s,
                          uint32_t xy[], int count, int x, int y) {
     SkASSERT(s.fInvMatrix.isScaleTranslate());
-    SkASSERT(s.fInvKy == 0);
 
     auto pack = [](SkFixed f, unsigned max, SkFixed one) {
         unsigned i = tile(f, max);
@@ -482,7 +481,6 @@ static const SkBitmapProcState::MatrixProc MirrorX_MirrorY_Procs[] = {
     static void filter_scale_neon(const SkBitmapProcState& s,
                                   uint32_t xy[], int count, int x, int y) {
         SkASSERT(s.fInvMatrix.isScaleTranslate());
-        SkASSERT(s.fInvKy == 0);
 
         auto pack = [&](SkFixed f, unsigned max, SkFixed one) {
             unsigned i = tile(f, max);