Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fb712f9

Browse files
author
nturgut
committed
some argument changes
1 parent 4e425a2 commit fb712f9

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

lib/web_ui/dev/integration_tests_manager.dart

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -165,15 +165,15 @@ class IntegrationTestsManager {
165165
IntegrationArguments.fromBrowser(_browser);
166166
final int exitCode = await runProcess(
167167
executable,
168-
arguments.getTestArguments(testName, 'release'),
168+
arguments.getTestArguments(testName, 'debug'),
169169
workingDirectory: directory.path,
170170
);
171171

172172
if (exitCode != 0) {
173173
io.stderr
174174
.writeln('ERROR: Failed to run test. Exited with exit code $exitCode'
175175
'. To run $testName locally use the following command:'
176-
'\n\n${arguments.getCommandToRun(testName, 'release')}');
176+
'\n\n${arguments.getCommandToRun(testName, 'debug')}');
177177
return false;
178178
} else {
179179
return true;
@@ -334,14 +334,14 @@ class ChromeIntegrationArguments extends IntegrationArguments {
334334
'--$mode',
335335
'--browser-name=chrome',
336336
if (isLuci) '--chrome-binary=${preinstalledChromeExecutable()}',
337-
if (isLuci) '--headless',
337+
'--headless',
338338
'--local-engine=host_debug_unopt',
339339
];
340340
}
341341

342342
String getCommandToRun(String testName, String mode) {
343343
String statementToRun = 'flutter drive '
344-
'--target=test_driver/${testName} -d web-server --release '
344+
'--target=test_driver/${testName} -d web-server --debug '
345345
'--browser-name=chrome --local-engine=host_debug_unopt';
346346
if (isLuci) {
347347
statementToRun = '$statementToRun --chrome-binary='
@@ -359,7 +359,7 @@ class FirefoxIntegrationArguments extends IntegrationArguments {
359359
'--target=test_driver/${testName}',
360360
'-d',
361361
'web-server',
362-
'--$mode',
362+
'--release', // Keep running Firefox on release mode.
363363
'--browser-name=firefox',
364364
'--headless',
365365
'--local-engine=host_debug_unopt',
@@ -380,7 +380,7 @@ class SafariIntegrationArguments extends IntegrationArguments {
380380
'--target=test_driver/${testName}',
381381
'-d',
382382
'web-server',
383-
'--$mode',
383+
'--release', // Keep running Safari on release mode.
384384
'--browser-name=safari',
385385
'--local-engine=host_debug_unopt',
386386
];

lib/web_ui/dev/test_runner.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ class TestCommand extends Command<bool> with ArgUtils {
158158
}
159159

160160
Future<bool> runIntegrationTests() async {
161+
await _prepare();
161162
return IntegrationTestsManager(browser, useSystemFlutter).runTests();
162163
}
163164

@@ -192,6 +193,7 @@ class TestCommand extends Command<bool> with ArgUtils {
192193

193194
// If screenshot tests are available, fetch the screenshot goldens.
194195
if (isScreenshotTestsAvailable) {
196+
print('screenshot tests available');
195197
final GoldensRepoFetcher goldensRepoFetcher = GoldensRepoFetcher(
196198
environment.webUiGoldensRepositoryDirectory,
197199
path.join(environment.webUiDevDir.path, 'goldens_lock.yaml'));

0 commit comments

Comments
 (0)