Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fadf7d7

Browse files
[Impeller] no-op fragment program on Android until it works. (#43657)
The framework has switched into mat3 by default, which means the fragment program ink sparkle has replaced the default ink splash. Since this is not implemented, all of the impeller benchmarks are crashign. No-op this so we at least get benchmark numbers until its implemented.
1 parent 9c6e539 commit fadf7d7

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

impeller/entity/contents/runtime_effect_contents.cc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,13 @@ bool RuntimeEffectContents::CanInheritOpacity(const Entity& entity) const {
4444
bool RuntimeEffectContents::Render(const ContentContext& renderer,
4545
const Entity& entity,
4646
RenderPass& pass) const {
47+
// TODO(jonahwilliams): FragmentProgram API is not fully wired up on Android.
48+
// Disable until this is complete so that integration tests and benchmarks can
49+
// run m3 applications.
50+
#ifdef FML_OS_ANDROID
51+
return true;
52+
#endif
53+
4754
auto context = renderer.GetContext();
4855
auto library = context->GetShaderLibrary();
4956

0 commit comments

Comments
 (0)