Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit f4afdb3

Browse files
alexmarkovcommit-bot@chromium.org
alexmarkov
authored and
commit-bot@chromium.org
committed
[Tests] Skip slow co19 tests on simarm* and aot/debug configurations
These tests involve large list literals which are very slow to compile in AOT/debug mode, or they perform a large amount of work which is too slow on simulated architectures (simarm, simarm64). Closes dart-lang/sdk#43614 Change-Id: Iafe1407247cc69e641d1e63f47b4c3d9f6eea35f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168782 Reviewed-by: Siva Annamalai <asiva@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Markov <alexmarkov@google.com>
1 parent 2759677 commit f4afdb3

File tree

2 files changed

+43
-2
lines changed

2 files changed

+43
-2
lines changed

‎tests/co19/co19-runtime.status‎

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,29 @@ LibTest/async/Stream/Stream.periodic_all_t02: Skip # Issue 42898
1212
[ $compiler != dart2js && $runtime != none && $runtime != vm && !$checked ]
1313
LibTest/async/Future/catchError_A03_t05: RuntimeError
1414

15-
[ $mode == debug && $nnbd != legacy && $runtime == dart_precompiled ]
16-
LibTest/collection/ListMixin/ListMixin_class_A01_t05: SkipSlow # Issue 43614
15+
[ $mode == debug && $runtime == dart_precompiled ]
16+
LibTest/collection/ListBase/ListBase_class_A01_t03: SkipSlow # Very slow compilation in debug mode.
17+
LibTest/collection/ListBase/ListBase_class_A01_t04: SkipSlow # Very slow compilation in debug mode.
18+
LibTest/collection/ListBase/ListBase_class_A01_t05: SkipSlow # Very slow compilation in debug mode.
19+
LibTest/collection/ListBase/ListBase_class_A01_t06: SkipSlow # Very slow compilation in debug mode.
20+
LibTest/collection/ListMixin/ListMixin_class_A01_t03: SkipSlow # Very slow compilation in debug mode.
21+
LibTest/collection/ListMixin/ListMixin_class_A01_t04: SkipSlow # Very slow compilation in debug mode.
22+
LibTest/collection/ListMixin/ListMixin_class_A01_t05: SkipSlow # Very slow compilation in debug mode.
23+
LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # Very slow compilation in debug mode.
24+
LibTest/core/List/List_all_t03: SkipSlow # Very slow compilation in debug mode.
25+
LibTest/core/List/List_all_t04: SkipSlow # Very slow compilation in debug mode.
26+
LibTest/core/List/List_all_t05: SkipSlow # Very slow compilation in debug mode.
27+
LibTest/core/List/List_all_t06: SkipSlow # Very slow compilation in debug mode.
28+
29+
[ $arch == simarm || $arch == simarm64 ]
30+
LibTest/collection/ListBase/ListBase_class_A01_t01: SkipSlow # Very slow on sim* architectures.
31+
LibTest/collection/ListBase/ListBase_class_A01_t04: SkipSlow # Very slow on sim* architectures.
32+
LibTest/collection/ListBase/ListBase_class_A01_t05: SkipSlow # Very slow on sim* architectures.
33+
LibTest/collection/ListBase/ListBase_class_A01_t06: SkipSlow # Very slow on sim* architectures.
34+
LibTest/collection/ListMixin/ListMixin_class_A01_t01: SkipSlow # Very slow on sim* architectures.
35+
LibTest/collection/ListMixin/ListMixin_class_A01_t04: SkipSlow # Very slow on sim* architectures.
36+
LibTest/collection/ListMixin/ListMixin_class_A01_t05: SkipSlow # Very slow on sim* architectures.
37+
LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # Very slow on sim* architectures.
1738

1839
[ $compiler == fasta || $runtime == dart_precompiled || $runtime == vm ]
1940
LibTest/html/*: SkipByDesign # dart:html not supported on VM.

‎tests/co19_2/co19_2-runtime.status‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,25 @@ LibTest/core/Uri/parse_A05_t01: RuntimeError
99
[ $compiler != dart2js && $runtime != none && $runtime != vm && !$checked ]
1010
LibTest/async/Future/catchError_A03_t05: RuntimeError
1111

12+
[ $mode == debug && $runtime == dart_precompiled ]
13+
LibTest/collection/ListBase/ListBase_class_A01_t03: SkipSlow # Very slow compilation in debug mode.
14+
LibTest/collection/ListBase/ListBase_class_A01_t04: SkipSlow # Very slow compilation in debug mode.
15+
LibTest/collection/ListBase/ListBase_class_A01_t05: SkipSlow # Very slow compilation in debug mode.
16+
LibTest/collection/ListBase/ListBase_class_A01_t06: SkipSlow # Very slow compilation in debug mode.
17+
LibTest/collection/ListMixin/ListMixin_class_A01_t03: SkipSlow # Very slow compilation in debug mode.
18+
LibTest/collection/ListMixin/ListMixin_class_A01_t04: SkipSlow # Very slow compilation in debug mode.
19+
LibTest/collection/ListMixin/ListMixin_class_A01_t05: SkipSlow # Very slow compilation in debug mode.
20+
LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # Very slow compilation in debug mode.
21+
22+
[ $arch == simarm || $arch == simarm64 ]
23+
LibTest/collection/ListBase/ListBase_class_A01_t01: SkipSlow # Very slow on sim* architectures.
24+
LibTest/collection/ListBase/ListBase_class_A01_t04: SkipSlow # Very slow on sim* architectures.
25+
LibTest/collection/ListBase/ListBase_class_A01_t05: SkipSlow # Very slow on sim* architectures.
26+
LibTest/collection/ListBase/ListBase_class_A01_t06: SkipSlow # Very slow on sim* architectures.
27+
LibTest/collection/ListMixin/ListMixin_class_A01_t01: SkipSlow # Very slow on sim* architectures.
28+
LibTest/collection/ListMixin/ListMixin_class_A01_t04: SkipSlow # Very slow on sim* architectures.
29+
LibTest/collection/ListMixin/ListMixin_class_A01_t05: SkipSlow # Very slow on sim* architectures.
30+
LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # Very slow on sim* architectures.
31+
1232
[ $compiler == fasta || $runtime == dart_precompiled || $runtime == vm ]
1333
LibTest/html/*: SkipByDesign # dart:html not supported on VM.

0 commit comments

Comments
 (0)