do not wrap font family name in webkit otherwise icons not show on safari 13 (both IOS and desktop)

Nurhan Turgut · Nurhan Turgut · commit f2a5a1fb4fd4 · 2019-10-04T10:55:31.000-07:00
diff --git a/lib/web_ui/lib/src/engine/text/font_collection.dart b/lib/web_ui/lib/src/engine/text/font_collection.dart
@@ -118,7 +118,7 @@ class _FontManager {
     // family that is not correct CSS syntax. To ensure the font family is
     // accepted on these browsers, wrap it in quotes.
     // See: https://drafts.csswg.org/css-fonts-3/#font-family-prop
-    if (browserEngine == BrowserEngine.webkit || browserEngine == BrowserEngine.firefox) {
+    if (browserEngine == BrowserEngine.firefox) {
       family = "'$family'";
     }
     // try/catch because `new FontFace` can crash with an improper font family.

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ class _FontManager {`
`118`	`118`	`// family that is not correct CSS syntax. To ensure the font family is`
`119`	`119`	`// accepted on these browsers, wrap it in quotes.`
`120`	`120`	`// See: https://drafts.csswg.org/css-fonts-3/#font-family-prop`
`121`		`- if (browserEngine == BrowserEngine.webkit \|\| browserEngine == BrowserEngine.firefox) {`
	`121`	`+ if (browserEngine == BrowserEngine.firefox) {`
`122`	`122`	`family = "'$family'";`
`123`	`123`	`}`
`124`	`124`	// try/catch because `new FontFace` can crash with an improper font family.