Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e893583

Browse files
committed
Update the comments
1 parent 22ff40c commit e893583

File tree

9 files changed

+15
-7
lines changed

9 files changed

+15
-7
lines changed

runtime/dart_isolate.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,8 @@ class DartIsolate : public UIDartState {
169169
/// function to invoke.
170170
/// @param[in] dart_entrypoint_library The name of the dart library
171171
/// containing the entrypoint.
172+
/// @param[in] dart_entrypoint_args Arguments passed as a List<String>
173+
/// to Dart's entrypoint function.
172174
/// @param[in] isolate_configuration The isolate configuration used to
173175
/// configure the isolate before
174176
/// invoking the entrypoint.

runtime/runtime_controller.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ class RuntimeController : public PlatformConfigurationClient {
126126
/// @param[in] dart_entrypoint_library The dart entrypoint library. If
127127
/// `std::nullopt` or empty, the core
128128
/// library will be attempted.
129+
/// @param[in] dart_entrypoint_args Arguments passed as a List<String>
130+
/// to Dart's entrypoint function.
129131
/// @param[in] isolate_configuration The isolate configuration
130132
///
131133
/// @return If the isolate could be launched and guided to the

shell/common/engine.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ const std::string& Engine::GetLastEntrypointLibrary() const {
569569
return last_entry_point_library_;
570570
}
571571

572-
const std::vector<std::string> Engine::GetLastEntrypointArgs() const {
572+
const std::vector<std::string>& Engine::GetLastEntrypointArgs() const {
573573
return last_entry_point_args_;
574574
}
575575

shell/common/engine.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,11 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
834834
///
835835
const std::string& GetLastEntrypointLibrary() const;
836836

837-
const std::vector<std::string> GetLastEntrypointArgs() const;
837+
//----------------------------------------------------------------------------
838+
/// @brief Get the last Entrypoint Arguments that was used in the
839+
/// RunConfiguration when |Engine::Run| was called.
840+
///
841+
const std::vector<std::string>& GetLastEntrypointArgs() const;
838842

839843
//----------------------------------------------------------------------------
840844
/// @brief Getter for the initial route. This can be set with a platform

shell/common/run_configuration.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ class RunConfiguration {
175175

176176
//----------------------------------------------------------------------------
177177
/// @return Arguments passed as a List<String> to Dart's entrypoint
178-
/// function.
178+
/// function.
179179
///
180180
std::vector<std::string> GetEntrypointArgs() const;
181181

shell/platform/android/io/flutter/embedding/engine/FlutterEngine.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,7 +383,7 @@ private boolean isAttachedToJni() {
383383
* @param initialRoute The name of the initial Flutter `Navigator` `Route` to load. If this is
384384
* null, it will default to the "/" route.
385385
* @param initialArguments The structured data for Flutter app at startup.It must be serializable
386-
* via the {@link io.flutter.plugin.common.StandardMessageCodec}.
386+
* via the {@link io.flutter.plugin.common.JSONMessageCodec}.
387387
* @return a new {@link io.flutter.embedding.engine.FlutterEngine}.
388388
*/
389389
@NonNull

shell/platform/android/io/flutter/embedding/engine/dart/DartExecutor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public void executeDartEntrypoint(@NonNull DartEntrypoint dartEntrypoint) {
129129
*
130130
* @param dartEntrypoint specifies which Dart function to run, and where to find it
131131
* @param initialArguments The structured data for Flutter app at startup.It must be serializable
132-
* via the {@link io.flutter.plugin.common.StandardMessageCodec}.
132+
* via the {@link io.flutter.plugin.common.JSONMessageCodec}.
133133
*/
134134
public void executeDartEntrypoint(
135135
@NonNull DartEntrypoint dartEntrypoint, @Nullable Object initialArguments) {

shell/platform/darwin/ios/framework/Headers/FlutterEngine.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ FLUTTER_DARWIN_EXPORT
262262
* @param initialRoute The name of the initial Flutter `Navigator` `Route` to load. If this is
263263
* FlutterDefaultInitialRoute (or nil), it will default to the "/" route.
264264
* @param initialArguments The structured data for Flutter app at startup.It must be serializable
265-
* via the FlutterStandardMessageCodec.
265+
* via the FlutterJSONMessageCodec.
266266
* @return YES if the call succeeds in creating and running a Flutter Engine instance; NO otherwise.
267267
*/
268268
- (BOOL)runWithEntrypoint:(nullable NSString*)entrypoint

shell/platform/darwin/ios/framework/Headers/FlutterEngineGroup.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ FLUTTER_DARWIN_EXPORT
7979
* @param initialRoute The name of the initial Flutter `Navigator` `Route` to load. If this is
8080
* FlutterDefaultInitialRoute (or nil), it will default to the "/" route.
8181
* @param initialArguments The structured data for Flutter app at startup.It must be serializable
82-
* via the FlutterStandardMessageCodec.
82+
* via the FlutterJSONMessageCodec.
8383
* @see FlutterEngineGroup
8484
*/
8585
- (FlutterEngine*)makeEngineWithEntrypoint:(nullable NSString*)entrypoint

0 commit comments

Comments
 (0)