[vm/compiler] Handle unboxed index parameter in ArraySetIndexed/ArrayGetIndexed intrinsics

Fixes dart-lang/sdk#43810

Change-Id: I0bd5fc1ca9b71c141bf6b596813183b380e1a391
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167865
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>

Author: alexmarkov

runtime/tests/vm/dart/regress_43810_test.dart

@@ -0,0 +1,22 @@
+// Copyright (c) 2020, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Verifies that intrinsic Float64List.[]= works even if parameters are
+// unboxed.
+// Regression test for https://github.com/dart-lang/sdk/issues/43810.
+
+import 'dart:typed_data';
+import 'package:expect/expect.dart';
+
+main() {
+  final list1 = <double>[
+    1, 2, 3, 4,
+  ];
+  var list = new Float64List(list1.length);
+  list.setRange(0, list1.length, list1);
+  Expect.equals(1.0, list[0]);
+  Expect.equals(2.0, list[1]);
+  Expect.equals(3.0, list[2]);
+  Expect.equals(4.0, list[3]);
+}

runtime/vm/compiler/graph_intrinsifier.cc

@@ -180,6 +180,19 @@ static Definition* PrepareIndexedOp(FlowGraph* flow_graph,
   return safe_index;
 }
 
+static Definition* CreateBoxedParameterIfNeeded(BlockBuilder* builder,
+                                                Definition* value,
+                                                Representation representation,
+                                                intptr_t arg_index) {
+  const auto& function = builder->function();
+  if (function.is_unboxed_parameter_at(arg_index)) {
+    return builder->AddDefinition(
+        BoxInstr::Create(representation, new Value(value)));
+  } else {
+    return value;
+  }
+}
+
 static Definition* CreateBoxedResultIfNeeded(BlockBuilder* builder,
                                              Definition* value,
                                              Representation representation) {
@@ -212,6 +225,7 @@ static bool IntrinsifyArrayGetIndexed(FlowGraph* flow_graph,
   Definition* array = builder.AddParameter(0, /*with_frame=*/false);
   Definition* index = builder.AddParameter(1, /*with_frame=*/false);
 
+  index = CreateBoxedParameterIfNeeded(&builder, index, kUnboxedInt64, 1);
   index = PrepareIndexedOp(flow_graph, &builder, array, index,
                            Slot::GetLengthFieldForArrayCid(array_cid));
 
@@ -314,6 +328,7 @@ static bool IntrinsifyArraySetIndexed(FlowGraph* flow_graph,
   Definition* index = builder.AddParameter(1, /*with_frame=*/false);
   Definition* value = builder.AddParameter(2, /*with_frame=*/false);
 
+  index = CreateBoxedParameterIfNeeded(&builder, index, kUnboxedInt64, 1);
   index = PrepareIndexedOp(flow_graph, &builder, array, index,
                            Slot::GetLengthFieldForArrayCid(array_cid));