Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit e4ddd6e

Browse files
committed
Ensure init test does not use global config.
1 parent d03a103 commit e4ddd6e

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

lib/web_ui/test/canvaskit/initialization/initialization_stores_config_test.dart

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,16 @@ void main() {
1414
void testMain() {
1515
group('initializeEngineServices', () {
1616
test('stores user configuration', () async {
17-
await initializeEngineServices(
18-
jsConfiguration: js_util.jsify(<String, Object?>{
19-
'canvasKitMaximumSurfaces': 32,
20-
}) as JsFlutterConfiguration);
17+
// dev/test_platform.dart injects a global configuration object. Let's
18+
// fetch that, override one of its properties (under test), then delete it
19+
// from window (so our configuration asserts don't fire!)
20+
final JsFlutterConfiguration config = js_util.getProperty(domWindow, 'flutterConfiguration');
21+
js_util.setProperty(config, 'canvasKitMaximumSurfaces', 32);
22+
js_util.setProperty(domWindow, 'flutterConfiguration', null);
2123

22-
expect(configuration.canvasKitMaximumSurfaces, 32);
24+
await initializeEngineServices(jsConfiguration: config);
2325

26+
expect(configuration.canvasKitMaximumSurfaces, 32);
2427
});
2528
});
2629
}

0 commit comments

Comments
 (0)