Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d7f987e

Browse files
authored
[Impeller] Eliminate unused shader output (#36923)
1 parent d6d38ab commit d7f987e

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

impeller/entity/shaders/position.vert

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@ uniform VertInfo {
1212
in vec2 position;
1313

1414
out vec4 v_color;
15-
out vec2 v_position;
1615

1716
void main() {
1817
gl_Position = vert_info.mvp * vec4(position, 0.0, 1.0);
1918
v_color = vert_info.color;
20-
v_position = IPVec2TransformPosition(vert_info.mvp, position);
2119
}

impeller/entity/shaders/position_color.vert

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,8 @@ in vec2 position;
1212
in vec4 color;
1313

1414
out vec4 v_color;
15-
out vec2 v_position;
1615

1716
void main() {
1817
gl_Position = vert_info.mvp * vec4(position, 0.0, 1.0);
1918
v_color = color;
20-
v_position = IPVec2TransformPosition(vert_info.mvp, position);
2119
}

impeller/renderer/backend/vulkan/pipeline_library_vk.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,8 @@ std::unique_ptr<PipelineCreateInfoVK> PipelineLibraryVK::CreatePipeline(
387387
auto pipeline =
388388
device_.createGraphicsPipelineUnique(cache_.get(), pipeline_info);
389389
if (pipeline.result != vk::Result::eSuccess) {
390-
VALIDATION_LOG << "Could not create graphics pipeline: " << desc.GetLabel();
390+
VALIDATION_LOG << "Could not create graphics pipeline - " << desc.GetLabel()
391+
<< ": " << vk::to_string(pipeline.result);
391392
return nullptr;
392393
}
393394

0 commit comments

Comments
 (0)