Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d2d4ae0

Browse files
committed
[benchmark] Test --no-sound-null-safety on legacy web benchmarks.
Bug: b/241766173 Change-Id: I83b132fe1b7832d0520391a94d346d26db4f3766 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271101 Reviewed-by: William Hesse <whesse@google.com>
1 parent a76a43f commit d2d4ae0

File tree

1 file changed

+10
-16
lines changed

1 file changed

+10
-16
lines changed

tools/bots/try_benchmarks.sh

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -178,19 +178,13 @@ EOF
178178
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety KernelServiceCompileAll
179179
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot UseDartApi
180180
out/ReleaseIA32/run_vm_tests --dfe=out/ReleaseIA32/kernel-service.dart.snapshot --sound-null-safety UseDartApi
181-
out/ReleaseIA32/dart --profile-period=10000 benchmarks/Example/dart2/Example.dart
181+
out/ReleaseIA32/dart --profile-period=10000 benchmarks/Example/dart/Example.dart
182182
out/ReleaseIA32/dart --sound-null-safety --profile-period=10000 benchmarks/Example/dart/Example.dart
183-
out/ReleaseIA32/dart benchmarks/NativeCall/dart2/NativeCall.dart
184183
out/ReleaseIA32/dart --sound-null-safety benchmarks/NativeCall/dart/NativeCall.dart
185-
out/ReleaseIA32/dart benchmarks/FfiBoringssl/dart2/FfiBoringssl.dart
186184
out/ReleaseIA32/dart --sound-null-safety benchmarks/FfiBoringssl/dart/FfiBoringssl.dart
187-
out/ReleaseIA32/dart benchmarks/FfiAsTypedList/dart2/FfiAsTypedList.dart
188185
out/ReleaseIA32/dart --sound-null-safety benchmarks/FfiAsTypedList/dart/FfiAsTypedList.dart
189-
out/ReleaseIA32/dart benchmarks/FfiCall/dart2/FfiCall.dart
190186
out/ReleaseIA32/dart --sound-null-safety benchmarks/FfiCall/dart/FfiCall.dart
191-
out/ReleaseIA32/dart benchmarks/FfiMemory/dart2/FfiMemory.dart
192187
out/ReleaseIA32/dart --sound-null-safety benchmarks/FfiMemory/dart/FfiMemory.dart
193-
out/ReleaseIA32/dart benchmarks/FfiStruct/dart2/FfiStruct.dart
194188
out/ReleaseIA32/dart --sound-null-safety benchmarks/FfiStruct/dart/FfiStruct.dart
195189
cd ..
196190
rm -rf tmp
@@ -320,23 +314,23 @@ EOF
320314
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/precompiler2 --sound-null-safety hello.dart blob.bin
321315
DART_CONFIGURATION=ReleaseX64 pkg/vm/tool/dart_precompiled_runtime2 --profile-period=10000 blob.bin
322316
out/ReleaseX64/dart --profile-period=10000 --optimization-counter-threshold=-1 hello.dart
323-
out/ReleaseX64/dart-sdk/bin/dart compile js --out=out.js -m hello.dart
317+
out/ReleaseX64/dart-sdk/bin/dart compile js --no-sound-null-safety --out=out.js -m hello.dart
324318
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
325319
out/ReleaseX64/dart-sdk/bin/dart compile js --sound-null-safety --out=out.js -m hello.dart
326320
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
327-
out/ReleaseX64/dart-sdk/bin/dart compile js --out=out.js -m hello.dart
328-
out/ReleaseX64/dart-sdk/bin/dart --print_metrics compile js --out=out.js -m hello.dart
321+
out/ReleaseX64/dart-sdk/bin/dart compile js --no-sound-null-safety --out=out.js -m hello.dart
322+
out/ReleaseX64/dart-sdk/bin/dart --print_metrics compile js --no-sound-null-safety --out=out.js -m hello.dart
329323
LD_LIBRARY_PATH=third_party/firefox_jsshell/ third_party/firefox_jsshell/js -f sdk/lib/_internal/js_runtime/lib/preambles/jsshell.js -f out.js
330324
out/ReleaseX64/dart-sdk/bin/dart compile js --sound-null-safety --out=out.js -m hello.dart
331325
LD_LIBRARY_PATH=third_party/firefox_jsshell/ third_party/firefox_jsshell/js -f sdk/lib/_internal/js_runtime/lib/preambles/jsshell.js -f out.js
332-
out/ReleaseX64/dart-sdk/bin/dart compile js --benchmarking-production --out=out.js -m hello.dart
326+
out/ReleaseX64/dart-sdk/bin/dart compile js --no-sound-null-safety --benchmarking-production --out=out.js -m hello.dart
333327
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
334328
out/ReleaseX64/dart-sdk/bin/dart compile js --sound-null-safety --benchmarking-production --out=out.js -m hello.dart
335329
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
336-
out/ReleaseX64/dart-sdk/bin/dart compile js --benchmarking-x --out=out.js -m hello.dart
330+
out/ReleaseX64/dart-sdk/bin/dart compile js --no-sound-null-safety --benchmarking-x --out=out.js -m hello.dart
337331
third_party/d8/linux/x64/d8 --stack_size=1024 sdk/lib/_internal/js_runtime/lib/preambles/d8.js out.js
338-
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 hello.dart
339-
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
332+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --no-sound-null-safety hello.dart
333+
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --no-sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
340334
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --sound-null-safety hello.dart
341335
out/ReleaseX64/dart-sdk/bin/dart pkg/dev_compiler/tool/ddb -r d8 -b third_party/d8/linux/x64/d8 --sound-null-safety --mode=compile --compile-vm-options=--print-metrics --out out.js hello.dart
342336
out/ReleaseX64/dart pkg/front_end/tool/perf.dart parse hello.dart
@@ -354,9 +348,9 @@ EOF
354348
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety KernelServiceCompileAll
355349
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot UseDartApi
356350
out/ReleaseX64/run_vm_tests --dfe=out/ReleaseX64/kernel-service.dart.snapshot --sound-null-safety UseDartApi
357-
out/ReleaseX64/dart --profile-period=10000 benchmarks/Example/dart2/Example.dart
351+
out/ReleaseX64/dart --profile-period=10000 benchmarks/Example/dart/Example.dart
358352
out/ReleaseX64/dart --sound-null-safety --profile-period=10000 benchmarks/Example/dart/Example.dart
359-
out/ReleaseX64/dart --profile-period=10000 benchmarks/IsolateSpawn/dart2/IsolateSpawn.dart
353+
out/ReleaseX64/dart --sound-null-safety --profile-period=10000 benchmarks/IsolateSpawn/dart/IsolateSpawn.dart
360354
cd ..
361355
rm -rf tmp
362356
else

0 commit comments

Comments
 (0)