Add test

Author: gspencergoog

shell/platform/linux/fl_platform_plugin.cc

@@ -244,6 +244,7 @@ static void request_app_exit(FlPlatformPlugin* self, const char* type) {
   if (!self->app_initialization_complete ||
       g_str_equal(type, kExitTypeRequired)) {
     quit_application();
+    return;
   }
 
   fl_value_set_string_take(args, kExitTypeKey, fl_value_new_string(type));

shell/platform/linux/fl_platform_plugin.h

@@ -38,9 +38,12 @@ FlPlatformPlugin* fl_platform_plugin_new(FlBinaryMessenger* messenger);
  * @plugin: an #FlPlatformPlugin
  *
  * Request the application exits (i.e. due to the window being requested to be
- * closed). Will only actually send a request to the framework to ask if it
- * should exit if the framework has indicated that it is ready to receive
- * requests.
+ * closed).
+ *
+ * Calling this will only send an exit request to the framework if the framework
+ * has already indicated that it is ready to receive requests by sending a
+ * "System.initializationComplete" method call on the platform channel. Calls
+ * before initialization is complete will result in an immediate exit.
  */
 void fl_platform_plugin_request_app_exit(FlPlatformPlugin* plugin);
 

shell/platform/linux/fl_platform_plugin_test.cc

@@ -112,22 +112,28 @@ TEST(FlPlatformPluginTest, ExitApplication) {
 
   g_autoptr(FlPlatformPlugin) plugin = fl_platform_plugin_new(messenger);
   EXPECT_NE(plugin, nullptr);
-
-  g_autoptr(FlValue) args = fl_value_new_map();
-  fl_value_set_string_take(args, "type", fl_value_new_string("cancelable"));
   g_autoptr(FlJsonMethodCodec) codec = fl_json_method_codec_new();
-  g_autoptr(GBytes) message = fl_method_codec_encode_method_call(
-      FL_METHOD_CODEC(codec), "System.exitApplication", args, nullptr);
 
   g_autoptr(FlValue) requestArgs = fl_value_new_map();
   fl_value_set_string_take(requestArgs, "type",
                            fl_value_new_string("cancelable"));
+
+  // Indicate that the binding is initialized.
+  g_autoptr(GBytes) init_message = fl_method_codec_encode_method_call(
+      FL_METHOD_CODEC(codec), "System.initializationComplete", nullptr,
+      nullptr);
+  messenger.ReceiveMessage("flutter/platform", init_message);
+
   EXPECT_CALL(messenger,
               fl_binary_messenger_send_on_channel(
                   ::testing::Eq<FlBinaryMessenger*>(messenger),
                   ::testing::StrEq("flutter/platform"),
                   MethodCall("System.requestAppExit", FlValueEq(requestArgs)),
                   ::testing::_, ::testing::_, ::testing::_));
 
+  g_autoptr(FlValue) args = fl_value_new_map();
+  fl_value_set_string_take(args, "type", fl_value_new_string("cancelable"));
+  g_autoptr(GBytes) message = fl_method_codec_encode_method_call(
+      FL_METHOD_CODEC(codec), "System.exitApplication", args, nullptr);
   messenger.ReceiveMessage("flutter/platform", message);
 }