Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d04f9c9

Browse files
committed
Address feedback
1 parent 9284755 commit d04f9c9

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

lib/ui/pointer.dart

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -285,22 +285,26 @@ class PointerData {
285285

286286
/// For events with change of PointerChange.panZoomUpdate:
287287
///
288-
/// The current panning magnitude of the pan/zoom in the x direction, in physical pixels.
288+
/// The current panning magnitude of the pan/zoom in the x direction, in
289+
/// physical pixels.
289290
final double panX;
290291

291292
/// For events with change of PointerChange.panZoomUpdate:
292293
///
293-
/// The current panning magnitude of the pan/zoom in the x direction, in physical pixels.
294+
/// The current panning magnitude of the pan/zoom in the x direction, in
295+
/// physical pixels.
294296
final double panY;
295297

296298
/// For events with change of PointerChange.panZoomUpdate:
297299
///
298-
/// The difference in panning of the pan/zoom in the x direction since the latest panZoomUpdate event, in physical pixels.
300+
/// The difference in panning of the pan/zoom in the x direction since the
301+
/// latest panZoomUpdate event, in physical pixels.
299302
final double panDeltaX;
300303

301304
/// For events with change of PointerChange.panZoomUpdate:
302305
///
303-
/// The difference in panning of the pan/zoom in the y direction since the last panZoomUpdate event, in physical pixels.
306+
/// The difference in panning of the pan/zoom in the y direction since the
307+
/// last panZoomUpdate event, in physical pixels.
304308
final double panDeltaY;
305309

306310
/// For events with change of PointerChange.panZoomUpdate:

lib/ui/window/pointer_data.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,10 @@ struct alignas(8) PointerData {
5757
};
5858

5959
// Must match the PointerSignalKind enum in pointer.dart.
60-
enum class SignalKind : int64_t { kNone, kScroll };
60+
enum class SignalKind : int64_t {
61+
kNone,
62+
kScroll,
63+
};
6164

6265
int64_t embedder_id;
6366
int64_t time_stamp;

lib/ui/window/pointer_data_packet_converter.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,8 @@ PointerState PointerDataPacketConverter::EnsurePointerState(
347347
state.is_pan_zoom_active = false;
348348
state.physical_x = pointer_data.physical_x;
349349
state.physical_y = pointer_data.physical_y;
350-
state.pan_x = pointer_data.pan_x;
351-
state.pan_y = pointer_data.pan_y;
350+
state.pan_x = 0;
351+
state.pan_y = 0;
352352
states_[pointer_data.device] = state;
353353
return state;
354354
}

0 commit comments

Comments
 (0)