Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit cf2c8e6

Browse files
Mohan MaiyaCommit Bot
authored andcommitted
EGL: Relax test skip conditions for a few colorspace ImageTests
Relax test skip conditions for the following colorspace ImageTests - - SourceRenderbufferTargetTexture_Colorspace - SourceRenderbufferTargetTextureExternal_Colorspace - SourceRenderbufferTargetTextureExternalESSL3_Colorspace For these tests, it is sufficient to check for support of EGL_EXT_image_gl_colorspace extension Bug: angleproject:3756 Tests: angle_end2end_tests --gtest_filter=ImageTest.SourceRenderbufferTargetTexture*_Colorspace* Change-Id: I123fb14fc79e8f949a903b7586a0badf54297cfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2144549 Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com> Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
1 parent 469c029 commit cf2c8e6

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/tests/gl_tests/ImageTest.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,7 +1681,6 @@ TEST_P(ImageTest, SourceRenderbufferTargetTexture)
16811681

16821682
TEST_P(ImageTest, SourceRenderbufferTargetTexture_Colorspace)
16831683
{
1684-
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !IsGLExtensionEnabled("GL_EXT_sRGB"));
16851684
ANGLE_SKIP_TEST_IF(!hasImageGLColorspaceExt());
16861685
SourceRenderbufferTargetTexture_helper(kColorspaceAttribs);
16871686
}
@@ -1719,7 +1718,6 @@ TEST_P(ImageTest, SourceRenderbufferTargetTextureExternal)
17191718

17201719
TEST_P(ImageTest, SourceRenderbufferTargetTextureExternal_Colorspace)
17211720
{
1722-
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !IsGLExtensionEnabled("GL_EXT_sRGB"));
17231721
ANGLE_SKIP_TEST_IF(!hasImageGLColorspaceExt());
17241722
SourceRenderbufferTargetTextureExternal_helper(kColorspaceAttribs);
17251723
}
@@ -1760,7 +1758,6 @@ TEST_P(ImageTestES3, SourceRenderbufferTargetTextureExternalESSL3)
17601758

17611759
TEST_P(ImageTestES3, SourceRenderbufferTargetTextureExternalESSL3_Colorspace)
17621760
{
1763-
ANGLE_SKIP_TEST_IF(getClientMajorVersion() < 3 && !IsGLExtensionEnabled("GL_EXT_sRGB"));
17641761
ANGLE_SKIP_TEST_IF(!hasImageGLColorspaceExt());
17651762
SourceRenderbufferTargetTextureExternalESSL3_helper(kColorspaceAttribs);
17661763
}

0 commit comments

Comments
 (0)