Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c3085ea

Browse files
cnorthropCommit Bot
authored andcommitted
Vulkan: Set texel offset limits
This was blocking compilation for any new texture builtin that used offsets. Bug: angleproject:3622 Change-Id: I30b221741796b53f8e47e3aeeebfbde3f1976bd6 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1699062 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Cody Northrop <cnorthrop@google.com>
1 parent aded991 commit c3085ea

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/libANGLE/renderer/vulkan/vk_caps_utils.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,9 @@ void RendererVk::ensureCapsInitialized() const
260260
mNativeCaps.shaderStorageBufferOffsetAlignment =
261261
static_cast<GLuint>(mPhysicalDeviceProperties.limits.minStorageBufferOffsetAlignment);
262262

263+
mNativeCaps.minProgramTexelOffset = mPhysicalDeviceProperties.limits.minTexelOffset;
264+
mNativeCaps.maxProgramTexelOffset = mPhysicalDeviceProperties.limits.maxTexelOffset;
265+
263266
// There is no additional limit to the combined number of components. We can have up to a
264267
// maximum number of uniform buffers, each having the maximum number of components. Note that
265268
// this limit includes both components in and out of uniform buffers.

src/tests/deqp_support/deqp_gles3_test_expectations.txt

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -602,17 +602,6 @@
602602
3190 VULKAN : dEQP-GLES3.functional.texture.units.all_units.* = SKIP
603603
3190 VULKAN : dEQP-GLES3.functional.texture.units.8_units.* = SKIP
604604

605-
// New shader builtins for texture sampling:
606-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.textureoffset.* = SKIP
607-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.textureprojoffset.* = SKIP
608-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texturelodoffset.* = SKIP
609-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.textureprojlodoffset.* = SKIP
610-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texturegradoffset.* = SKIP
611-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.textureprojgradoffset.* = SKIP
612-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texelfetch.* = SKIP
613-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texelfetchoffset.* = SKIP
614-
3622 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texturesize.* = SKIP
615-
616605
// Formats:
617606
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.renderbuffer.color0.rgba32f = FAIL
618607
3677 ANDROID VULKAN : dEQP-GLES3.functional.fbo.completeness.renderable.texture.color0.rgba32f = FAIL
@@ -721,6 +710,7 @@
721710
3148 VULKAN : dEQP-GLES3.functional.state_query.texture.texture_cube_map_texture_base_level_gettexparameter* = SKIP
722711
3148 VULKAN : dEQP-GLES3.functional.texture.mipmap.*base_level* = SKIP
723712
3148 VULKAN : dEQP-GLES3.functional.texture.mipmap.*max_level* = SKIP
713+
3148 VULKAN : dEQP-GLES3.functional.shaders.texture_functions.texturesize.* = SKIP
724714

725715
// Misc unimplemented:
726716

0 commit comments

Comments
 (0)