Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c2b7566

Browse files
committed
[Impeller Scene] Rename mesh importer to scenec
1 parent f7df812 commit c2b7566

File tree

5 files changed

+28
-30
lines changed

5 files changed

+28
-30
lines changed

impeller/fixtures/BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ impeller_shaders("shader_fixtures") {
3333
}
3434
}
3535

36-
scene_importer("geometry_fixtures") {
36+
scenec("geometry_fixtures") {
3737
geometry = [ "flutter_logo.glb" ]
3838
type = "gltf"
3939
}

impeller/scene/importer/BUILD.gn

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ flatbuffers("importer_flatbuffers") {
1717
public_deps = [ "//third_party/flatbuffers" ]
1818
}
1919

20-
impeller_component("importer_lib") {
20+
impeller_component("scenec_lib") {
2121
# Current versions of libcxx have deprecated some of the UTF-16 string
2222
# conversion APIs.
2323
defines = [ "_LIBCPP_DISABLE_DEPRECATION_WARNINGS" ]
@@ -37,34 +37,34 @@ impeller_component("importer_lib") {
3737
"../../geometry",
3838
"//flutter/fml",
3939

40-
# All third_party deps must be reflected below in the scene_importer_license
40+
# All third_party deps must be reflected below in the scenec_license
4141
# target.
4242
# TODO(bdero): Fix tinygltf compilation warnings.
4343
#"//third_party/tinygltf",
4444
]
4545
}
4646

47-
generated_file("scene_importer_license") {
47+
generated_file("scenec_license") {
4848
source_path = rebase_path(".", "//flutter")
4949
git_url = "https://github.com/flutter/engine/tree/$engine_version"
50-
outputs = [ "$target_gen_dir/LICENSE.scene_importer.md" ]
50+
outputs = [ "$target_gen_dir/LICENSE.scenec.md" ]
5151
contents = [
52-
"# scene_importer",
52+
"# scenec",
5353
"",
5454
"This tool is used by the Flutter SDK to import 3D geometry.",
5555
"",
5656
"Source code for this tool: [flutter/engine/$source_path]($git_url/$source_path).",
5757
"",
5858
"## Licenses",
5959
"",
60-
"### scene_importer",
60+
"### scenec",
6161
"",
6262
read_file("//flutter/sky/packages/sky_engine/LICENSE", "string"),
6363
"",
6464

6565
# These licenses are ignored by the main license checker, since they are not
6666
# shipped to end-application binaries and only shipped as part of developer
67-
# tooling in scene_importer. Add them here.
67+
# tooling in scenec. Add them here.
6868
"## Additional open source licenses",
6969
"",
7070
"### tinygltf",
@@ -75,19 +75,19 @@ generated_file("scene_importer_license") {
7575

7676
group("importer") {
7777
deps = [
78-
":scene_importer",
79-
":scene_importer_license",
78+
":scenec",
79+
":scenec_license",
8080
]
8181
}
8282

83-
impeller_component("scene_importer") {
83+
impeller_component("scenec") {
8484
target_type = "executable"
8585

86-
sources = [ "importer_main.cc" ]
86+
sources = [ "scenec_main.cc" ]
8787

88-
deps = [ ":importer_lib" ]
88+
deps = [ ":scenec_lib" ]
8989

9090
metadata = {
91-
entitlement_file_path = [ "scene_importer" ]
91+
entitlement_file_path = [ "scenec" ]
9292
}
9393
}
File renamed without changes.

impeller/scene/importer/switches.cc

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ static const std::map<std::string, SourceType> kKnownSourceTypes = {
2323

2424
void Switches::PrintHelp(std::ostream& stream) {
2525
stream << std::endl;
26-
stream << "Scene Importer is an offline 3D geometry file parser."
27-
<< std::endl;
26+
stream << "SceneC is an offline 3D geometry file parser." << std::endl;
2827
stream << "---------------------------------------------------------------"
2928
<< std::endl;
3029
stream << "Valid Argument are:" << std::endl;

impeller/tools/impeller.gni

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ declare_args() {
2424
# If it is non-empty, it should be the absolute path to impellerc.
2525
impeller_use_prebuilt_impellerc = ""
2626

27-
# Whether to use a prebuilt scene_importer.
28-
# If this is the empty string, scene_importer will be built.
29-
# If it is non-empty, it should be the absolute path to scene_importer.
30-
impeller_use_prebuilt_scene_importer = ""
27+
# Whether to use a prebuilt scenec.
28+
# If this is the empty string, scenec will be built.
29+
# If it is non-empty, it should be the absolute path to scenec.
30+
impeller_use_prebuilt_scenec = ""
3131

3232
# If enabled, all OpenGL calls will be traced. Because additional trace
3333
# overhead may be substantial, this is not enabled by default.
@@ -622,32 +622,31 @@ template("impeller_shaders") {
622622
}
623623
}
624624

625-
# Dispatches to the build or prebuilt scene_importer depending on the value of
626-
# the impeller_use_prebuilt_scene_importer argument. Forwards all variables to
625+
# Dispatches to the build or prebuilt scenec depending on the value of
626+
# the impeller_use_prebuilt_scenec argument. Forwards all variables to
627627
# compiled_action_foreach or action_foreach as appropriate.
628-
template("_scene_importer") {
629-
if (impeller_use_prebuilt_scene_importer == "") {
628+
template("_scenec") {
629+
if (impeller_use_prebuilt_scenec == "") {
630630
compiled_action_foreach(target_name) {
631631
forward_variables_from(invoker, "*")
632-
tool = "//flutter/impeller/scene/importer:scene_importer"
632+
tool = "//flutter/impeller/scene/importer:scenec"
633633
}
634634
} else {
635635
action_foreach(target_name) {
636636
forward_variables_from(invoker, "*", [ "args" ])
637637
script = "//build/gn_run_binary.py"
638-
scene_importer_path =
639-
rebase_path(impeller_use_prebuilt_scene_importer, root_build_dir)
640-
args = [ scene_importer_path ] + invoker.args
638+
scenec_path = rebase_path(impeller_use_prebuilt_scenec, root_build_dir)
639+
args = [ scenec_path ] + invoker.args
641640
}
642641
}
643642
}
644643

645-
template("scene_importer") {
644+
template("scenec") {
646645
assert(defined(invoker.geometry), "Geometry input files must be specified.")
647646
assert(defined(invoker.type),
648647
"The type of geometry to be parsed (gltf, etc..).")
649648

650-
_scene_importer(target_name) {
649+
_scenec(target_name) {
651650
sources = invoker.geometry
652651
generated_dir = "$target_gen_dir"
653652

0 commit comments

Comments
 (0)