Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c2a0d0e

Browse files
Mike KleinSkia Commit-Bot
authored andcommitted
sub_f32 -> sub_f32_imm more sanely
Change-Id: Ic89359cd08298e73011952452ce909291d6f3fe9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/269947 Auto-Submit: Mike Klein <mtklein@google.com> Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
1 parent 5dd64f3 commit c2a0d0e

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/core/SkVM.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,6 @@ namespace skvm {
362362
default: break;
363363

364364
case Op::add_f32: imm_op = Op::add_f32_imm; goto try_imm_x_and_y;
365-
case Op::sub_f32: imm_op = Op::sub_f32_imm; goto try_imm_y;
366365
case Op::mul_f32: imm_op = Op::mul_f32_imm; goto try_imm_x_and_y;
367366
case Op::min_f32: imm_op = Op::min_f32_imm; goto try_imm_x_and_y;
368367
case Op::max_f32: imm_op = Op::max_f32_imm; goto try_imm_x_and_y;
@@ -376,14 +375,19 @@ namespace skvm {
376375
inst.x = inst.y;
377376
inst.y = NA;
378377
inst.immy = bits;
379-
} else
380-
try_imm_y:
381-
if (int bits; this->allImm(inst.y, &bits)) {
378+
} else if (int bits; this->allImm(inst.y, &bits)) {
382379
inst.op = imm_op;
383380
inst.y = NA;
384381
inst.immy = bits;
385382
} break;
386383

384+
case Op::sub_f32:
385+
if (int bits; this->allImm(inst.y, &bits)) {
386+
inst.op = Op::sub_f32_imm;
387+
inst.y = NA;
388+
inst.immy = bits;
389+
} break;
390+
387391
case Op::bit_clear:
388392
if (int bits; this->allImm(inst.y, &bits)) {
389393
inst.op = Op::bit_and_imm;

0 commit comments

Comments
 (0)