Revert "Build iOS unittest target in unopt builds (#44301)"

Chris Yang · web-flow · commit c0d2b8ccc7be · 2023-08-03T15:31:04.000-07:00
This reverts commit 9c17c35.
diff --git a/shell/platform/darwin/ios/BUILD.gn b/shell/platform/darwin/ios/BUILD.gn
@@ -264,6 +264,7 @@ source_set("ios_test_flutter_mrc") {
 }
 
 shared_library("ios_test_flutter") {
+  testonly = true
   visibility = [ ":*" ]
   cflags = [
     "-fvisibility=default",
@@ -303,6 +304,7 @@ shared_library("ios_test_flutter") {
     "framework/Source/connection_collection_test.mm",
   ]
   deps = [
+    ":flutter_framework",
     ":flutter_framework_source",
     ":flutter_framework_source_arc",
     ":ios_gpu_configuration",
@@ -465,8 +467,4 @@ action("flutter_framework") {
   ]
 
   deps = [ ":universal_flutter_framework" ]
-
-  if (is_debug) {
-    deps += [ ":ios_test_flutter" ]
-  }
 }

Original file line number	Diff line number	Diff line change
`@@ -264,6 +264,7 @@ source_set("ios_test_flutter_mrc") {`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`shared_library("ios_test_flutter") {`
	`267`	`+ testonly = true`
`267`	`268`	`visibility = [ ":*" ]`
`268`	`269`	`cflags = [`
`269`	`270`	`"-fvisibility=default",`
`@@ -303,6 +304,7 @@ shared_library("ios_test_flutter") {`
`303`	`304`	`"framework/Source/connection_collection_test.mm",`
`304`	`305`	`]`
`305`	`306`	`deps = [`
	`307`	`+ ":flutter_framework",`
`306`	`308`	`":flutter_framework_source",`
`307`	`309`	`":flutter_framework_source_arc",`
`308`	`310`	`":ios_gpu_configuration",`
`@@ -465,8 +467,4 @@ action("flutter_framework") {`
`465`	`467`	`]`
`466`	`468`
`467`	`469`	`deps = [ ":universal_flutter_framework" ]`
`468`		`-`
`469`		`- if (is_debug) {`
`470`		`- deps += [ ":ios_test_flutter" ]`
`471`		`- }`
`472`	`470`	`}`