Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c012941

Browse files
mkustermanncommit-bot@chromium.org
authored andcommitted
[gardening] Lower threshold for number of trace events in flaky/time-sensitive test
Issue dart-lang/sdk#43713 Change-Id: I6884d08ff08e0e44efcb14b009d9289dba8909ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168021 Commit-Queue: Martin Kustermann <kustermann@google.com> Reviewed-by: Tess Strickland <sstrickl@google.com> Auto-Submit: Martin Kustermann <kustermann@google.com>
1 parent 94985b1 commit c012941

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Future checkTimeline(VM vm) async {
3838
}
3939

4040
List events = result['traceEvents'];
41-
expect(events.length, greaterThan(10), reason: "Should have many samples");
41+
expect(events.length, greaterThan(0), reason: "Should have samples");
4242
for (Map event in events) {
4343
expect(event['ph'], equals('P'));
4444
expect(event['pid'], isInt);

runtime/observatory_2/tests/service_2/get_cpu_profile_timeline_rpc_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Future checkTimeline(VM vm) async {
3838
}
3939

4040
List events = result['traceEvents'];
41-
expect(events.length, greaterThan(10), reason: "Should have many samples");
41+
expect(events.length, greaterThan(0), reason: "Should have samples");
4242
for (Map event in events) {
4343
expect(event['ph'], equals('P'));
4444
expect(event['pid'], isInt);

0 commit comments

Comments
 (0)