[dart2js] Mark native classes as needed if they have new-rti is-tests or

named type variables.

Change-Id: I12af7f8595d6580cac4bc98cad5cd7795f6a71ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127964
Commit-Queue: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>

Author: fishythefish

pkg/compiler/lib/src/js_backend/runtime_types_codegen.dart

@@ -61,6 +61,8 @@ class ClassChecks {
 
   Iterable<TypeCheck> get checks => _map.values;
 
+  bool get isEmpty => _map.isEmpty;
+
   @override
   String toString() {
     return 'ClassChecks($checks)';

pkg/compiler/lib/src/js_emitter/native_emitter.dart

@@ -251,9 +251,13 @@ class NativeEmitter {
           field.needsCheckedSetter;
     }
 
+    // TODO(fishythefish): Have trivial classes redirect to their supertypes in
+    // the ruleset.
     return cls.methods.isEmpty &&
         cls.isChecks.isEmpty &&
+        (cls.classChecksNewRti == null || cls.classChecksNewRti.isEmpty) &&
         cls.callStubs.isEmpty &&
+        cls.namedTypeVariablesNewRti.isEmpty &&
         !cls.superclass.isSimpleMixinApplication &&
         !cls.fields.any(needsAccessor);
   }

tests/compiler/dart2js/rti/emission/event_callback.dart

@@ -7,10 +7,10 @@ import 'dart:html';
 /*strong.class: global#Event:checkedInstance,checkedTypeArgument,checks=[$isEvent],instance,typeArgument*/
 
 /*strong.class: global#MouseEvent:checks=[$isMouseEvent],instance,typeArgument*/
-/*omit.class: global#MouseEvent:instance*/
+/*omit.class: global#MouseEvent:checks=[],instance*/
 
 /*strong.class: global#KeyboardEvent:checks=[$isKeyboardEvent],instance,typeArgument*/
-/*omit.class: global#KeyboardEvent:instance*/
+/*omit.class: global#KeyboardEvent:checks=[],instance*/
 
 void main() {
   print('InputElement');

tests/compiler/dart2js/rti/emission/native.dart

@@ -12,7 +12,8 @@ import 'dart:_foreign_helper' show JS;
 @Native('PPPP')
 class Purple {}
 
-/*class: Q:instance*/
+/*strong.class: Q:checks=[],instance*/
+/*omit.class: Q:instance*/
 @Native('QQQQ')
 class Q {}
 

tests/compiler/dart2js_native/error_safeToString_test.dart

@@ -1,6 +1,8 @@
 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
+//
+// dart2jsOptions=--no-minify
 
 import "native_testing.dart";
 import 'dart:_foreign_helper' show JS_INTERCEPTOR_CONSTANT;
@@ -147,7 +149,7 @@ testNative() {
   print('Q:  $x  ${Error.safeToString(x)}');
   // We are going to get either the general interceptor or the JavaScript
   // constructor.
-  Expect.isTrue("Instance of 'QQQQ'" == Error.safeToString(x) ||
+  Expect.isTrue("Instance of 'Q'" == Error.safeToString(x) ||
       interceptorString == Error.safeToString(x));
 
   x = makeR();