Remove dependencies on _product variants of libdart from the Fuchsia release mode build (#21668)

Author: jason-simmons

shell/platform/fuchsia/BUILD.gn

@@ -10,11 +10,9 @@ import("//flutter/tools/fuchsia/dart.gni")
 import("//flutter/tools/fuchsia/fuchsia_host_bundle.gni")
 
 product_suffix = ""
-is_product = false
 
 if (flutter_runtime_mode == "release") {
   product_suffix = "product_"
-  is_product = true
 }
 
 fuchsia_host_bundle("flutter_binaries") {
@@ -35,7 +33,7 @@ fuchsia_host_bundle("dart_binaries") {
   name = "dart_binaries"
 
   _gen_snapshot_to_use = gen_snapshot + "($host_toolchain)"
-  if (is_product) {
+  if (flutter_runtime_mode == "release") {
     _gen_snapshot_to_use = gen_snapshot_product + "($host_toolchain)"
   }
 

shell/platform/fuchsia/dart_runner/BUILD.gn

@@ -93,8 +93,8 @@ runner("dart_jit_product_runner_bin") {
   product = true
   extra_defines = [ "DART_PRODUCT" ]
   extra_deps = [
-    "//third_party/dart/runtime:libdart_jit_product",
-    "//third_party/dart/runtime/platform:libdart_platform_jit_product",
+    "//third_party/dart/runtime:libdart_jit",
+    "//third_party/dart/runtime/platform:libdart_platform_jit",
   ]
 }
 
@@ -121,8 +121,8 @@ runner("dart_aot_product_runner_bin") {
   ]
   extra_deps = [
     "embedder:dart_aot_product_snapshot_cc",
-    "//third_party/dart/runtime:libdart_precompiled_runtime_product",
-    "//third_party/dart/runtime/platform:libdart_platform_precompiled_runtime_product",
+    "//third_party/dart/runtime:libdart_precompiled_runtime",
+    "//third_party/dart/runtime/platform:libdart_platform_precompiled_runtime",
   ]
 }
 

shell/platform/fuchsia/flutter/BUILD.gn

@@ -229,8 +229,8 @@ flutter_runner("jit_product") {
   product = true
 
   extra_deps = [
-    "//third_party/dart/runtime:libdart_jit_product",
-    "//third_party/dart/runtime/platform:libdart_platform_jit_product",
+    "//third_party/dart/runtime:libdart_jit",
+    "//third_party/dart/runtime/platform:libdart_platform_jit",
   ]
 }
 
@@ -249,8 +249,8 @@ flutter_runner("aot_product") {
   product = true
 
   extra_deps = [
-    "//third_party/dart/runtime:libdart_precompiled_runtime_product",
-    "//third_party/dart/runtime/platform:libdart_platform_precompiled_runtime_product",
+    "//third_party/dart/runtime:libdart_precompiled_runtime",
+    "//third_party/dart/runtime/platform:libdart_platform_precompiled_runtime",
   ]
 }