Deprecate LinkInputLibrary/LinkInputUnit.tmp1(), use unnamed instead.

This is the next step to rename these constructors.
After updating google3 to unnamed constructors we will remove `tmp1`.

Change-Id: Ib010ad6c2de6918dc9daceaa7d27449618ebd9b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202200
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/analyzer/lib/dart/sdk/build_sdk_summary.dart

@@ -135,7 +135,7 @@ class _Builder {
 
     CompilationUnit definingUnit = _parse(source);
     inputUnits.add(
-      LinkInputUnit.tmp1(
+      LinkInputUnit(
         partDirectiveIndex: null,
         source: source,
         isSynthetic: false,
@@ -154,7 +154,7 @@ class _Builder {
         Source partSource = context.sourceFactory.resolveUri(source, partUri)!;
         CompilationUnit partUnit = _parse(partSource);
         inputUnits.add(
-          LinkInputUnit.tmp1(
+          LinkInputUnit(
             partUriStr: partUri,
             partDirectiveIndex: partDirectiveIndex++,
             source: partSource,
@@ -166,7 +166,7 @@ class _Builder {
     }
 
     inputLibraries.add(
-      LinkInputLibrary.tmp1(
+      LinkInputLibrary(
         source: source,
         units: inputUnits,
       ),

pkg/analyzer/lib/src/dart/analysis/library_context.dart

@@ -145,7 +145,7 @@ class LibraryContext {
             partIndex++;
 
             inputUnits.add(
-              link2.LinkInputUnit.tmp1(
+              link2.LinkInputUnit(
                 // TODO(scheglov) bad, group part data
                 partDirectiveIndex: partIndex - 1,
                 partUriStr: partUriStr,
@@ -157,7 +157,7 @@ class LibraryContext {
           }
 
           inputLibraries.add(
-            link2.LinkInputLibrary.tmp1(
+            link2.LinkInputLibrary(
               source: librarySource,
               units: inputUnits,
             ),

pkg/analyzer/lib/src/dart/micro/resolve_file.dart

@@ -875,7 +875,7 @@ class _LibraryContext {
             partIndex++;
 
             inputUnits.add(
-              link2.LinkInputUnit.tmp1(
+              link2.LinkInputUnit(
                 // TODO(scheglov) bad, group part data
                 partDirectiveIndex: partIndex - 1,
                 partUriStr: partUriStr,
@@ -887,7 +887,7 @@ class _LibraryContext {
           }
 
           inputLibraries.add(
-            link2.LinkInputLibrary.tmp1(
+            link2.LinkInputLibrary(
               source: librarySource,
               units: inputUnits,
             ),

pkg/analyzer/lib/src/summary2/link.dart

@@ -246,9 +246,12 @@ class LinkInputLibrary {
   final Source source;
   final List<LinkInputUnit> units;
 
-  @Deprecated('Use LinkInputLibrary.tmp1() with instead')
-  LinkInputLibrary(this.source, this.units);
+  LinkInputLibrary({
+    required this.source,
+    required this.units,
+  });
 
+  @Deprecated('Use LinkInputLibrary() with instead')
   LinkInputLibrary.tmp1({
     required this.source,
     required this.units,
@@ -266,14 +269,15 @@ class LinkInputUnit {
   final bool isSynthetic;
   final ast.CompilationUnit unit;
 
-  @Deprecated('Use LinkInputUnit.tmp1() with instead')
-  LinkInputUnit(
+  LinkInputUnit({
+    required this.partDirectiveIndex,
     this.partUriStr,
-    this.source,
-    this.isSynthetic,
-    this.unit,
-  ) : partDirectiveIndex = null;
+    required this.source,
+    required this.isSynthetic,
+    required this.unit,
+  });
 
+  @Deprecated('Use LinkInputUnit() with instead')
   LinkInputUnit.tmp1({
     required this.partDirectiveIndex,
     this.partUriStr,

pkg/analyzer/test/src/summary/resynthesize_ast2_test.dart

@@ -59,7 +59,7 @@ class ResynthesizeAst2Test extends AbstractResynthesizeTest
       var inputUnits = <LinkInputUnit>[];
       _addLibraryUnits(source, unit, inputUnits, featureSet);
       inputLibraries.add(
-        LinkInputLibrary.tmp1(
+        LinkInputLibrary(
           source: source,
           units: inputUnits,
         ),
@@ -147,7 +147,7 @@ class ResynthesizeAst2Test extends AbstractResynthesizeTest
     FeatureSet featureSet,
   ) {
     units.add(
-      LinkInputUnit.tmp1(
+      LinkInputUnit(
         partDirectiveIndex: null,
         source: definingSource,
         isSynthetic: false,
@@ -170,7 +170,7 @@ class ResynthesizeAst2Test extends AbstractResynthesizeTest
           var text = _readSafely(partSource.fullName);
           var unit = parseText(text, featureSet);
           units.add(
-            LinkInputUnit.tmp1(
+            LinkInputUnit(
               partDirectiveIndex: partDirectiveIndex,
               partUriStr: relativeUriStr,
               source: partSource,
@@ -200,7 +200,7 @@ class ResynthesizeAst2Test extends AbstractResynthesizeTest
     var units = <LinkInputUnit>[];
     _addLibraryUnits(source, unit, units, featureSet);
     libraries.add(
-      LinkInputLibrary.tmp1(
+      LinkInputLibrary(
         source: source,
         units: units,
       ),