Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ab0a620

Browse files
committed
fix conflict
1 parent 65eea60 commit ab0a620

File tree

5 files changed

+19
-32
lines changed

5 files changed

+19
-32
lines changed

display_list/display_list_builder.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -277,11 +277,11 @@ void DisplayListBuilder::onSetColorFilter(const DlColorFilter* filter) {
277277
}
278278
void DisplayListBuilder::onSetPathEffect(const DlPathEffect* effect) {
279279
if (effect == nullptr) {
280-
current_path_effect_ = nullptr;
280+
current_.setPathEffect(nullptr);
281281
Push<ClearPathEffectOp>(0, 0);
282282
} else {
283-
current_path_effect_ = effect->shared();
284-
switch (current_path_effect_->type()) {
283+
current_.setPathEffect(effect->shared());
284+
switch (effect->type()) {
285285
case DlPathEffectType::kDash: {
286286
const DlDashPathEffect* dash_effect = effect->asDash();
287287
void* pod = Push<SetPodPathEffectOp>(dash_effect->size(), 0);

display_list/display_list_builder.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include "flutter/display_list/display_list_flags.h"
1313
#include "flutter/display_list/display_list_image.h"
1414
#include "flutter/display_list/display_list_paint.h"
15+
#include "flutter/display_list/display_list_path_effect.h"
1516
#include "flutter/display_list/types.h"
1617
#include "flutter/fml/macros.h"
1718

@@ -103,7 +104,7 @@ class DisplayListBuilder final : public virtual Dispatcher,
103104
}
104105
}
105106
void setPathEffect(const DlPathEffect* effect) override {
106-
if (NotEquals(current_path_effect_, effect)) {
107+
if (NotEquals(current_.getPathEffect(), effect)) {
107108
onSetPathEffect(effect);
108109
}
109110
}
@@ -140,7 +141,7 @@ class DisplayListBuilder final : public virtual Dispatcher,
140141
: SkBlender::Mode(ToSk(current_.getBlendMode()));
141142
}
142143
std::shared_ptr<const DlPathEffect> getPathEffect() const {
143-
return current_path_effect_;
144+
return current_.getPathEffect();
144145
}
145146
std::shared_ptr<const DlMaskFilter> getMaskFilter() const {
146147
return current_.getMaskFilter();
@@ -462,7 +463,6 @@ class DisplayListBuilder final : public virtual Dispatcher,
462463
DlPaint current_;
463464
// If |current_blender_| is set then ignore |current_.getBlendMode()|
464465
sk_sp<SkBlender> current_blender_;
465-
sk_sp<SkPathEffect> current_path_effect_;
466466
};
467467

468468
} // namespace flutter

display_list/display_list_dispatcher.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
#include "flutter/display_list/display_list_image.h"
1313
#include "flutter/display_list/display_list_image_filter.h"
1414
#include "flutter/display_list/display_list_mask_filter.h"
15+
#include "flutter/display_list/display_list_paint.h"
1516
#include "flutter/display_list/display_list_path_effect.h"
1617
#include "flutter/display_list/display_list_vertices.h"
1718

display_list/display_list_paint.h

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,14 @@
55
#ifndef FLUTTER_DISPLAY_LIST_DISPLAY_LIST_PAINT_H_
66
#define FLUTTER_DISPLAY_LIST_DISPLAY_LIST_PAINT_H_
77

8+
#include <memory>
89
#include "flutter/display_list/display_list_blend_mode.h"
910
#include "flutter/display_list/display_list_color.h"
1011
#include "flutter/display_list/display_list_color_filter.h"
1112
#include "flutter/display_list/display_list_color_source.h"
1213
#include "flutter/display_list/display_list_image_filter.h"
1314
#include "flutter/display_list/display_list_mask_filter.h"
15+
#include "flutter/display_list/display_list_path_effect.h"
1416

1517
namespace flutter {
1618

@@ -199,6 +201,15 @@ class DlPaint {
199201
return *this;
200202
}
201203

204+
std::shared_ptr<const DlPathEffect> getPathEffect() const {
205+
return pathEffect_;
206+
}
207+
const DlPathEffect* getPathEffectPtr() const { return pathEffect_.get(); }
208+
DlPaint& setPathEffect(std::shared_ptr<DlPathEffect> pathEffect) {
209+
pathEffect_ = pathEffect;
210+
return *this;
211+
}
212+
202213
bool operator==(DlPaint const& other) const;
203214
bool operator!=(DlPaint const& other) const { return !(*this == other); }
204215

@@ -236,8 +247,8 @@ class DlPaint {
236247
std::shared_ptr<const DlColorFilter> colorFilter_;
237248
std::shared_ptr<const DlImageFilter> imageFilter_;
238249
std::shared_ptr<const DlMaskFilter> maskFilter_;
250+
std::shared_ptr<const DlPathEffect> pathEffect_;
239251
// missing (as compared to SkPaint):
240-
// DlPathEffect - waiting for https://github.com/flutter/engine/pull/32159
241252
// DlBlender - not planning on using that object in a pure DisplayList world
242253
};
243254

impeller/LICENSE

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)