Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a8e6a46

Browse files
null77Commit Bot
authored andcommitted
Suppress Vulkan RobustResourceInit tests.
These tests are flaky because of a bug in ANGLE's Vulkan robust resource init. Mark them as failing until we can resolve the bug. Bug: angleproject:4255 Bug: angleproject:4384 Change-Id: I8e18a8532850848fc7a25e137dce27dd0d19fa55 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046053 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org>
1 parent 0a6e118 commit a8e6a46

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

src/tests/gl_tests/RobustResourceInitTest.cpp

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,9 @@ TEST_P(RobustResourceInitTest, ReadingUninitializedTexture)
528528
{
529529
ANGLE_SKIP_TEST_IF(!hasGLExtension());
530530

531+
// http://anglebug.com/4255
532+
ANGLE_SKIP_TEST_IF(IsVulkan());
533+
531534
GLTexture tex;
532535
setupTexture(&tex);
533536
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
@@ -544,6 +547,9 @@ TEST_P(RobustResourceInitTest, ReuploadingClearsTexture)
544547
// crbug.com/826576
545548
ANGLE_SKIP_TEST_IF(IsOSX() && IsNVIDIA() && IsDesktopOpenGL());
546549

550+
// http://anglebug.com/4255
551+
ANGLE_SKIP_TEST_IF(IsVulkan());
552+
547553
// Put some data into the texture
548554
std::array<GLColor, kWidth * kHeight> data;
549555
data.fill(GLColor::white);
@@ -568,6 +574,9 @@ TEST_P(RobustResourceInitTest, TexImageThenSubImage)
568574
// http://anglebug.com/2407, but only fails on Nexus devices
569575
ANGLE_SKIP_TEST_IF((IsNexus5X() || IsNexus6P()) && IsOpenGLES());
570576

577+
// http://anglebug.com/4255
578+
ANGLE_SKIP_TEST_IF(IsVulkan());
579+
571580
// Put some data into the texture
572581

573582
GLTexture tex;
@@ -594,6 +603,9 @@ TEST_P(RobustResourceInitTestES3, ReadingUninitialized3DTexture)
594603
{
595604
ANGLE_SKIP_TEST_IF(!hasGLExtension());
596605

606+
// http://anglebug.com/4255
607+
ANGLE_SKIP_TEST_IF(IsVulkan());
608+
597609
GLTexture tex;
598610
setup3DTexture(&tex);
599611
glTexImage3D(GL_TEXTURE_3D, 0, GL_RGBA, kWidth, kHeight, 2, 0, GL_RGBA, GL_UNSIGNED_BYTE,
@@ -756,6 +768,9 @@ TEST_P(RobustResourceInitTest, UninitializedPartsOfCopied2DTexturesAreBlack)
756768
{
757769
ANGLE_SKIP_TEST_IF(!hasGLExtension());
758770

771+
// http://anglebug.com/4255
772+
ANGLE_SKIP_TEST_IF(IsVulkan());
773+
759774
GLTexture tex;
760775
setupTexture(&tex);
761776
GLFramebuffer fbo;
@@ -790,6 +805,9 @@ TEST_P(RobustResourceInitTestES3, ReadingOutOfBoundsCopiedTextureWithUnpackBuffe
790805
// glCopyTextureCHROMIUM to copy GL_ALPHA into GL_RGBA
791806
ANGLE_SKIP_TEST_IF(!IsGLExtensionEnabled("GL_CHROMIUM_copy_texture"));
792807

808+
// http://anglebug.com/4255
809+
ANGLE_SKIP_TEST_IF(IsVulkan());
810+
793811
GLFramebuffer fbo;
794812
glBindFramebuffer(GL_FRAMEBUFFER, fbo);
795813
GLRenderbuffer rbo;
@@ -840,10 +858,8 @@ TEST_P(RobustResourceInitTest, ReadingOutOfBoundsCopiedTexture)
840858
{
841859
ANGLE_SKIP_TEST_IF(!hasGLExtension());
842860

843-
// Flaky failure on Linux / NV / Vulkan when run in a sequence. http://anglebug.com/3416
844-
ANGLE_SKIP_TEST_IF(IsVulkan() && IsNVIDIA() && IsLinux());
845-
// http://anglebug.com/4092
846-
ANGLE_SKIP_TEST_IF(IsWindows() && IsVulkan());
861+
// http://anglebug.com/4255
862+
ANGLE_SKIP_TEST_IF(IsVulkan());
847863

848864
GLTexture tex;
849865
setupTexture(&tex);
@@ -930,6 +946,9 @@ TEST_P(RobustResourceInitTest, Texture)
930946
// Flaky failure on Linux / NV / Vulkan when run in a sequence. http://anglebug.com/3416
931947
ANGLE_SKIP_TEST_IF(IsVulkan() && IsNVIDIA() && IsLinux());
932948

949+
// http://anglebug.com/4255
950+
ANGLE_SKIP_TEST_IF(IsVulkan());
951+
933952
GLTexture texture;
934953
glBindTexture(GL_TEXTURE_2D, texture);
935954
glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, kWidth, kHeight, 0, GL_RGBA, GL_UNSIGNED_BYTE, nullptr);
@@ -1616,6 +1635,9 @@ TEST_P(RobustResourceInitTestES3, Texture2DArray)
16161635
{
16171636
ANGLE_SKIP_TEST_IF(!hasGLExtension());
16181637

1638+
// http://anglebug.com/4255
1639+
ANGLE_SKIP_TEST_IF(IsVulkan());
1640+
16191641
constexpr int kSize = 1024;
16201642
constexpr int kLayers = 8;
16211643

0 commit comments

Comments
 (0)