Clear frame references at the end of every CanvasKit frame (#16525)

Harry Terkelsen · web-flow · commit a662579f7cc3 · 2020-02-10T15:30:24.000-08:00
diff --git a/lib/web_ui/lib/src/engine/compositor/rasterizer.dart b/lib/web_ui/lib/src/engine/compositor/rasterizer.dart
@@ -37,7 +37,8 @@ class Rasterizer {
       final SurfaceFrame frame = surface.acquireFrame(layerTree.frameSize);
       surface.viewEmbedder.frameSize = layerTree.frameSize;
       final SkCanvas canvas = frame.skiaCanvas;
-      final Frame compositorFrame = context.acquireFrame(canvas, surface.viewEmbedder);
+      final Frame compositorFrame =
+          context.acquireFrame(canvas, surface.viewEmbedder);
 
       compositorFrame.raster(layerTree, ignoreRasterCache: true);
       surface.addToScene();
@@ -57,5 +58,9 @@ class Rasterizer {
       final ui.VoidCallback callback = _postFrameCallbacks[i];
       callback();
     }
+    for (int i = 0; i < _frameReferences.length; i++) {
+      _frameReferences[i].value = null;
+    }
+    _frameReferences.clear();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,8 @@ class Rasterizer {`
`37`	`37`	`final SurfaceFrame frame = surface.acquireFrame(layerTree.frameSize);`
`38`	`38`	`surface.viewEmbedder.frameSize = layerTree.frameSize;`
`39`	`39`	`final SkCanvas canvas = frame.skiaCanvas;`
`40`		`- final Frame compositorFrame = context.acquireFrame(canvas, surface.viewEmbedder);`
	`40`	`+ final Frame compositorFrame =`
	`41`	`+ context.acquireFrame(canvas, surface.viewEmbedder);`
`41`	`42`
`42`	`43`	`compositorFrame.raster(layerTree, ignoreRasterCache: true);`
`43`	`44`	`surface.addToScene();`
`@@ -57,5 +58,9 @@ class Rasterizer {`
`57`	`58`	`final ui.VoidCallback callback = _postFrameCallbacks[i];`
`58`	`59`	`callback();`
`59`	`60`	`}`
	`61`	`+ for (int i = 0; i < _frameReferences.length; i++) {`
	`62`	`+ _frameReferences[i].value = null;`
	`63`	`+ }`
	`64`	`+ _frameReferences.clear();`
`60`	`65`	`}`
`61`	`66`	`}`